feat!: generate UID without randombytes dependency (yahoo#196)

Author: valadaptive

.github/workflows/test.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18.x, 20.x, 22.x]
+        node-version: [20.x, 22.x, 24.x]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}

index.js

@@ -6,8 +6,6 @@ See the accompanying LICENSE file for terms.
 
 'use strict';
 
-var randomBytes = require('randombytes');
-
 // Generate an internal UID to make the regexp pattern harder to guess.
 var UID_LENGTH          = 16;
 var UID                 = generateUID();
@@ -35,7 +33,7 @@ function escapeUnsafeChars(unsafeChar) {
 }
 
 function generateUID() {
-    var bytes = randomBytes(UID_LENGTH);
+    var bytes = crypto.getRandomValues(new Uint8Array(UID_LENGTH));
     var result = '';
     for(var i=0; i<UID_LENGTH; ++i) {
         result += bytes[i].toString(16);

package-lock.json

@@ -27,7 +27,7 @@
   "devDependencies": {
     "benchmark": "^2.1.4"
   },
-  "dependencies": {
-    "randombytes": "^2.1.0"
+  "engines": {
+    "node": ">=20.0.0"
   }
 }

package.json

@@ -3,20 +3,6 @@ const { deepStrictEqual, strictEqual, throws } = require('node:assert');
 
 var serialize = require('../../');
 
-// temporarily monkeypatch `crypto.randomBytes` so we'll have a
-// predictable UID for our tests
-var crypto = require('crypto');
-var oldRandom = crypto.randomBytes;
-crypto.randomBytes = function(len, cb) {
-    var buf = Buffer.alloc(len);
-    buf.fill(0x00);
-    if (cb)
-        cb(null, buf);
-    return buf;
-};
-
-crypto.randomBytes = oldRandom;
-
 describe('serialize( obj )', function () {
     it('should be a function', function () {
         strictEqual(typeof serialize, 'function');