Merge pull request AsyncHttpClient#112 from slandelle/master

Clean up some logging

Author: jfarcand

src/main/java/com/ning/http/client/providers/apache/ApacheAsyncHttpProvider.java

@@ -859,7 +859,7 @@ public boolean isDone() {
          */
         public synchronized void run() {
             if (this.apacheResponseFuture != null && this.apacheResponseFuture.hasExpired()) {
-                logger.debug("Request Timeout expired for " + this.apacheResponseFuture);
+                logger.debug("Request Timeout expired for {}", this.apacheResponseFuture);
 
                 int requestTimeout = config.getRequestTimeoutInMs();
                 PerRequestConfig p = this.apacheResponseFuture.getRequest().getPerRequestConfig();

src/main/java/com/ning/http/client/providers/grizzly/GrizzlyAsyncHttpProvider.java

@@ -554,9 +554,7 @@ boolean sendRequest(final FilterChainContext ctx,
         } else {
             ctx.write(requestPacket, ctx.getTransportContext().getCompletionHandler());
         }
-        if (LOGGER.isDebugEnabled()) {
-            LOGGER.debug("REQUEST: " + requestPacket.toString());
-        }
+        LOGGER.debug("REQUEST: {}", requestPacket);
 
         return isWriteComplete;
     }
@@ -1221,9 +1219,7 @@ protected void onHttpHeadersParsed(HttpHeader httpHeader,
                                            FilterChainContext ctx) {
 
             super.onHttpHeadersParsed(httpHeader, ctx);
-            if (LOGGER.isDebugEnabled()) {
-                LOGGER.debug("RESPONSE: " + httpHeader.toString());
-            }
+            LOGGER.debug("RESPONSE: {}", httpHeader);
             if (httpHeader.containsHeader(Header.Connection)) {
                 if ("close".equals(httpHeader.getHeader(Header.Connection))) {
                     ConnectionManager.markConnectionAsDoNotCache(ctx.getConnection());

src/main/java/com/ning/http/client/providers/grizzly/GrizzlyConnectionsPool.java

@@ -100,10 +100,8 @@ public boolean offer(String uri, Connection connection) {
 
         DelayedExecutor.IdleConnectionQueue conQueue = connectionsPool.get(uri);
         if (conQueue == null) {
-            if (LOG.isDebugEnabled()) {
-                LOG.debug("Creating new Connection queue for uri [{}] and connection [{}]",
-                        new Object[]{uri, connection});
-            }
+            LOG.debug("Creating new Connection queue for uri [{}] and connection [{}]",
+                        uri, connection);
             DelayedExecutor.IdleConnectionQueue newPool =
                     delayedExecutor.createIdleConnectionQueue(timeout);
             conQueue = connectionsPool.putIfAbsent(uri, newPool);

src/main/java/com/ning/http/client/providers/netty/NettyConnectionsPool.java

@@ -126,7 +126,8 @@ public void run() {
                     }
                 }
 
-                log.trace(String.format("%d channel open, %d idle channels closed (times: 1st-loop=%d, 2nd-loop=%d).\n",
+                if (log.isTraceEnabled())
+                    log.trace(String.format("%d channel open, %d idle channels closed (times: 1st-loop=%d, 2nd-loop=%d).\n",
                         connectionsPool.size(), channelsInTimeout.size(), endConcurrentLoop - currentTime, System.currentTimeMillis() - endConcurrentLoop));
             } catch (Throwable t) {
                 log.error("uncaught exception!", t);