@@ -6,18 +6,20 @@ There are a few rules to get your merge request accepted:
6
6
7
7
1 . Your merge request should only be ** merged by a [ maintainer] [ team ] ** .
8
8
1 . If your merge request includes only backend changes [ ^ 1 ] , it must be
9
- ** approved by a [ backend maintainer] [ team ] ** .
9
+ ** approved by a [ backend maintainer] [ projects ] ** .
10
10
1 . If your merge request includes only frontend changes [ ^ 1 ] , it must be
11
- ** approved by a [ frontend maintainer] [ team ] ** .
11
+ ** approved by a [ frontend maintainer] [ projects ] ** .
12
12
1 . If your merge request includes frontend and backend changes [ ^ 1 ] , it must
13
- be ** approved by a [ frontend and a backend maintainer] [ team ] ** .
13
+ be ** approved by a [ frontend and a backend maintainer] [ projects ] ** .
14
14
1 . To lower the amount of merge requests maintainers need to review, you can
15
- ask or assign any [ reviewers] [ team ] for a first review.
15
+ ask or assign any [ reviewers] [ projects ] for a first review.
16
16
1 . If you need some guidance (e.g. it's your first merge request), feel free
17
17
to ask one of the [ Merge request coaches] [ team ] .
18
18
1 . The reviewer will assign the merge request to a maintainer once the
19
19
reviewer is satisfied with the state of the merge request.
20
20
21
+ For more guidance, see [ CONTRIBUTING.md] ( https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md ) .
22
+
21
23
## Best practices
22
24
23
25
This guide contains advice and best practices for performing code review, and
@@ -30,7 +32,7 @@ code is effective, understandable, and maintainable.
30
32
Any developer can, and is encouraged to, perform code review on merge requests
31
33
of colleagues and contributors. However, the final decision to accept a merge
32
34
request is up to one the project's maintainers, denoted on the
33
- [ team page ] ( https://about.gitlab.com/team ) .
35
+ [ engineering projects ] [ projects ] .
34
36
35
37
### Everyone
36
38
@@ -140,3 +142,6 @@ Largely based on the [thoughtbot code review guide].
140
142
---
141
143
142
144
[ Return to Development documentation] ( README.md )
145
+
146
+ [ projects ] : https://about.gitlab.com/handbook/engineering/projects/
147
+ [ team ] : https://about.gitlab.com/team/
0 commit comments