Skip to content

Commit 6075d7a

Browse files
committed
Merge branch 'update-cr-docs' into 'master'
Fix links in code review docs See merge request !11207
2 parents 388641a + 4b463dc commit 6075d7a

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

doc/development/code_review.md

+10-5
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,20 @@ There are a few rules to get your merge request accepted:
66

77
1. Your merge request should only be **merged by a [maintainer][team]**.
88
1. If your merge request includes only backend changes [^1], it must be
9-
**approved by a [backend maintainer][team]**.
9+
**approved by a [backend maintainer][projects]**.
1010
1. If your merge request includes only frontend changes [^1], it must be
11-
**approved by a [frontend maintainer][team]**.
11+
**approved by a [frontend maintainer][projects]**.
1212
1. If your merge request includes frontend and backend changes [^1], it must
13-
be **approved by a [frontend and a backend maintainer][team]**.
13+
be **approved by a [frontend and a backend maintainer][projects]**.
1414
1. To lower the amount of merge requests maintainers need to review, you can
15-
ask or assign any [reviewers][team] for a first review.
15+
ask or assign any [reviewers][projects] for a first review.
1616
1. If you need some guidance (e.g. it's your first merge request), feel free
1717
to ask one of the [Merge request coaches][team].
1818
1. The reviewer will assign the merge request to a maintainer once the
1919
reviewer is satisfied with the state of the merge request.
2020

21+
For more guidance, see [CONTRIBUTING.md](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md).
22+
2123
## Best practices
2224

2325
This guide contains advice and best practices for performing code review, and
@@ -30,7 +32,7 @@ code is effective, understandable, and maintainable.
3032
Any developer can, and is encouraged to, perform code review on merge requests
3133
of colleagues and contributors. However, the final decision to accept a merge
3234
request is up to one the project's maintainers, denoted on the
33-
[team page](https://about.gitlab.com/team).
35+
[engineering projects][projects].
3436

3537
### Everyone
3638

@@ -140,3 +142,6 @@ Largely based on the [thoughtbot code review guide].
140142
---
141143

142144
[Return to Development documentation](README.md)
145+
146+
[projects]: https://about.gitlab.com/handbook/engineering/projects/
147+
[team]: https://about.gitlab.com/team/

0 commit comments

Comments
 (0)