Store SQL/view timings in milliseconds

Transaction timings are also already stored in milliseconds, this keeps
things consistent.

Author: Yorick Peterse

lib/gitlab/metrics/subscribers/action_view.rb

@@ -19,7 +19,7 @@ def track(event)
           values = values_for(event)
           tags   = tags_for(event)
 
-          current_transaction.increment(:view_duration, event.duration)
+          current_transaction.increment(:view_duration, duration(event))
           current_transaction.add_metric(SERIES, values, tags)
         end
 
@@ -28,7 +28,7 @@ def relative_path(path)
         end
 
         def values_for(event)
-          { duration: event.duration }
+          { duration: duration(event) }
         end
 
         def tags_for(event)
@@ -48,6 +48,10 @@ def tags_for(event)
         def current_transaction
           Transaction.current
         end
+
+        def duration(event)
+          event.duration * 1000.0
+        end
       end
     end
   end

lib/gitlab/metrics/subscribers/active_record.rb

@@ -8,14 +8,18 @@ class ActiveRecord < ActiveSupport::Subscriber
         def sql(event)
           return unless current_transaction
 
-          current_transaction.increment(:sql_duration, event.duration)
+          current_transaction.increment(:sql_duration, duration(event))
         end
 
         private
 
         def current_transaction
           Transaction.current
         end
+
+        def duration(event)
+          event.duration * 1000.0
+        end
       end
     end
   end

spec/lib/gitlab/metrics/subscribers/action_view_spec.rb

@@ -21,15 +21,15 @@
 
   describe '#render_template' do
     it 'tracks rendering of a template' do
-      values = { duration: 2.1 }
+      values = { duration: 2100 }
       tags   = {
         view: 'app/views/x.html.haml',
         file: 'app/views/x.html.haml',
         line: 4
       }
 
       expect(transaction).to receive(:increment).
-        with(:view_duration, 2.1)
+        with(:view_duration, 2100)
 
       expect(transaction).to receive(:add_metric).
         with(described_class::SERIES, values, tags)

spec/lib/gitlab/metrics/subscribers/active_record_spec.rb

@@ -26,7 +26,7 @@
           and_return(transaction)
 
         expect(transaction).to receive(:increment).
-          with(:sql_duration, 0.2)
+          with(:sql_duration, 200)
 
         subscriber.sql(event)
       end