Skip to content

Commit a52d8c1

Browse files
committed
Merge branch 'fix_gitlab-ce#41891' into 'master'
fix gitlab-org/gitlab-ce#41891 (design nitpick) Closes #41891 See merge request gitlab-org/gitlab-ce!16383
2 parents 9978602 + 3c6d95a commit a52d8c1

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

app/assets/stylesheets/framework/header.scss

+4-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,10 @@
104104

105105
img {
106106
height: 28px;
107-
margin-right: 8px;
107+
108+
+ .logo-text {
109+
margin-left: 8px;
110+
}
108111
}
109112

110113
&.wrap {

app/views/layouts/header/_default.html.haml

+4-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@
66
%h1.title
77
= link_to root_path, title: 'Dashboard', id: 'logo' do
88
= brand_header_logo
9-
%span.logo-text.hidden-xs
10-
= brand_header_logo_type
9+
- logo_text = brand_header_logo_type
10+
- if logo_text.present?
11+
%span.logo-text.hidden-xs
12+
= logo_text
1113
1214
- if current_user
1315
= render "layouts/nav/dashboard"
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
title: 'Fix custom header logo design nitpick: Remove unneeded margin on empty logo text'
3+
merge_request: 16383
4+
author: Markus Doits
5+
type: fixed

0 commit comments

Comments
 (0)