Skip to content

Commit aaeda82

Browse files
committed
Add Y Label field to yml and responses
1 parent c24d20d commit aaeda82

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

config/additional_metrics.yml

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
priority: 1
33
metrics:
44
- title: "Memory usage"
5+
y_label: "Values"
56
detect: container_memory_usage_bytes
67
weight: 1
78
queries:

lib/gitlab/prometheus/metric.rb

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,21 @@
11
module Gitlab::Prometheus
22
class Metric
3-
attr_reader :group, :title, :detect, :weight, :queries
3+
attr_reader :group, :title, :detect, :weight, :y_label, :queries
44

5-
def initialize(group, title, detect, weight, queries = [])
5+
def initialize(group, title, detect, weight, y_label, queries = [])
66
@group = group
77
@title = title
88
@detect = detect
99
@weight = weight
10+
@y_label = y_label || 'Values'
1011
@queries = queries
1112
end
1213

1314
def self.metric_from_entry(group, entry)
1415
missing_fields = [:title, :detect, :weight, :queries].select { |key| !entry.has_key?(key) }
1516
raise ParsingError.new("entry missing required fields #{missing_fields}") unless missing_fields.empty?
1617

17-
Metric.new(group, entry[:title], entry[:detect], entry[:weight], entry[:queries])
18+
Metric.new(group, entry[:title], entry[:detect], entry[:weight], entry[:y_label],entry[:queries])
1819
end
1920

2021
def self.metrics_from_list(group, list)

lib/gitlab/prometheus/metrics_sources.rb

-7
This file was deleted.

lib/gitlab/prometheus/queries/additional_metrics_query.rb

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ def query_metrics(query_context)
2222
{
2323
title: metric.title,
2424
weight: metric.weight,
25+
y_label: metric.y_label,
2526
queries: metric.queries.map(&query_processor)
2627
}
2728
end

0 commit comments

Comments
 (0)