Remove default arguments for common query context

pawelchcki · pawelchcki · commit ba97a42193d8 · 2017-08-01T22:11:59.000+02:00
diff --git a/lib/gitlab/prometheus/queries/additional_metrics_environment_query.rb b/lib/gitlab/prometheus/queries/additional_metrics_environment_query.rb
@@ -6,7 +6,9 @@ class AdditionalMetricsEnvironmentQuery < BaseQuery
 
         def query(environment_id)
           Environment.find_by(id: environment_id).try do |environment|
-            query_metrics(common_query_context(environment))
+            query_metrics(
+              common_query_context(environment, timeframe_start: 8.hours.ago.to_f, timeframe_end: Time.now.to_f)
+            )
           end
         end
       end
diff --git a/lib/gitlab/prometheus/queries/query_additional_metrics.rb b/lib/gitlab/prometheus/queries/query_additional_metrics.rb
@@ -71,7 +71,7 @@ def matched_metrics
           result.select { |group| group.metrics.any? }
         end
 
-        def common_query_context(environment, timeframe_start: 8.hours.ago.to_f, timeframe_end: Time.now.to_f)
+        def common_query_context(environment, timeframe_start:, timeframe_end:)
           {
             timeframe_start: timeframe_start,
             timeframe_end: timeframe_end,

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ def matched_metrics`
`71`	`71`	`result.select { \|group\| group.metrics.any? }`
`72`	`72`	`end`
`73`	`73`
`74`		`- def common_query_context(environment, timeframe_start: 8.hours.ago.to_f, timeframe_end: Time.now.to_f)`
	`74`	`+ def common_query_context(environment, timeframe_start:, timeframe_end:)`
`75`	`75`	`{`
`76`	`76`	`timeframe_start: timeframe_start,`
`77`	`77`	`timeframe_end: timeframe_end,`