Skip to content

Commit d6e63f9

Browse files
committed
Merge branch 'vue-mr-widget-state' into 'master'
Move mr_widget_auto_merge_failed component into a vue file See merge request gitlab-org/gitlab-ce!16564
2 parents 6d9da73 + 5de8599 commit d6e63f9

File tree

4 files changed

+89
-69
lines changed

4 files changed

+89
-69
lines changed

app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_auto_merge_failed.js

-47
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
<script>
2+
import loadingIcon from '~/vue_shared/components/loading_icon.vue';
3+
import eventHub from '../../event_hub';
4+
import statusIcon from '../mr_widget_status_icon';
5+
6+
export default {
7+
name: 'MRWidgetAutoMergeFailed',
8+
components: {
9+
statusIcon,
10+
loadingIcon,
11+
},
12+
props: {
13+
mr: {
14+
type: Object,
15+
required: true,
16+
},
17+
},
18+
data() {
19+
return {
20+
isRefreshing: false,
21+
};
22+
},
23+
methods: {
24+
refreshWidget() {
25+
this.isRefreshing = true;
26+
eventHub.$emit('MRWidgetUpdateRequested', () => {
27+
this.isRefreshing = false;
28+
});
29+
},
30+
},
31+
};
32+
</script>
33+
<template>
34+
<div class="mr-widget-body media">
35+
<status-icon status="warning" />
36+
<div class="media-body space-children">
37+
<span class="bold">
38+
<template v-if="mr.mergeError">{{ mr.mergeError }}.</template>
39+
{{ s__("mrWidget|This merge request failed to be merged automatically") }}
40+
</span>
41+
<button
42+
@click="refreshWidget"
43+
:disabled="isRefreshing"
44+
type="button"
45+
class="btn btn-xs btn-default"
46+
>
47+
<loading-icon v-if="isRefreshing" />
48+
{{ s__("mrWidget|Refresh") }}
49+
</button>
50+
</div>
51+
</div>
52+
</template>

app/assets/javascripts/vue_merge_request_widget/dependencies.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export { default as PipelineBlockedState } from './components/states/mr_widget_p
3333
export { default as PipelineFailedState } from './components/states/mr_widget_pipeline_failed';
3434
export { default as MergeWhenPipelineSucceedsState } from './components/states/mr_widget_merge_when_pipeline_succeeds';
3535
export { default as RebaseState } from './components/states/mr_widget_rebase.vue';
36-
export { default as AutoMergeFailed } from './components/states/mr_widget_auto_merge_failed';
36+
export { default as AutoMergeFailed } from './components/states/mr_widget_auto_merge_failed.vue';
3737
export { default as CheckingState } from './components/states/mr_widget_checking';
3838
export { default as MRWidgetStore } from './stores/mr_widget_store';
3939
export { default as MRWidgetService } from './services/mr_widget_service';
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,47 @@
11
import Vue from 'vue';
2-
import autoMergeFailedComponent from '~/vue_merge_request_widget/components/states/mr_widget_auto_merge_failed';
3-
4-
const mergeError = 'This is the merge error';
2+
import autoMergeFailedComponent from '~/vue_merge_request_widget/components/states/mr_widget_auto_merge_failed.vue';
3+
import eventHub from '~/vue_merge_request_widget/event_hub';
4+
import mountComponent from '../../../helpers/vue_mount_component_helper';
55

66
describe('MRWidgetAutoMergeFailed', () => {
7-
describe('props', () => {
8-
it('should have props', () => {
9-
const mrProp = autoMergeFailedComponent.props.mr;
7+
let vm;
8+
const mergeError = 'This is the merge error';
109

11-
expect(mrProp.type instanceof Object).toBeTruthy();
12-
expect(mrProp.required).toBeTruthy();
10+
beforeEach(() => {
11+
const Component = Vue.extend(autoMergeFailedComponent);
12+
vm = mountComponent(Component, {
13+
mr: { mergeError },
1314
});
1415
});
1516

16-
describe('template', () => {
17-
const Component = Vue.extend(autoMergeFailedComponent);
18-
const vm = new Component({
19-
el: document.createElement('div'),
20-
propsData: {
21-
mr: { mergeError },
22-
},
23-
});
17+
afterEach(() => {
18+
vm.$destroy();
19+
});
20+
21+
it('renders failed message', () => {
22+
expect(vm.$el.textContent).toContain('This merge request failed to be merged automatically');
23+
});
24+
25+
it('renders merge error provided', () => {
26+
expect(vm.$el.innerText).toContain(mergeError);
27+
});
28+
29+
it('render refresh button', () => {
30+
expect(vm.$el.querySelector('button').textContent.trim()).toEqual('Refresh');
31+
});
32+
33+
it('emits event and shows loading icon when button is clicked', (done) => {
34+
spyOn(eventHub, '$emit');
35+
vm.$el.querySelector('button').click();
36+
37+
expect(eventHub.$emit.calls.argsFor(0)[0]).toEqual('MRWidgetUpdateRequested');
2438

25-
it('should have correct elements', () => {
26-
expect(vm.$el.classList.contains('mr-widget-body')).toBeTruthy();
27-
expect(vm.$el.querySelector('button').getAttribute('disabled')).toBeFalsy();
28-
expect(vm.$el.innerText).toContain('This merge request failed to be merged automatically');
29-
expect(vm.$el.innerText).toContain(mergeError);
39+
Vue.nextTick(() => {
40+
expect(vm.$el.querySelector('button').getAttribute('disabled')).toEqual('disabled');
41+
expect(
42+
vm.$el.querySelector('button i').classList,
43+
).toContain('fa-spinner');
44+
done();
3045
});
3146
});
3247
});

0 commit comments

Comments
 (0)