Skip to content

Commit e6c7c11

Browse files
committed
replace has_matching_label with has_matching_label?
1 parent eb0a17b commit e6c7c11

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.rubocop_todo.yml

+3
Original file line numberDiff line numberDiff line change
@@ -244,8 +244,11 @@ Style/PerlBackrefs:
244244
# NameWhitelist: is_a?
245245
Style/PredicateName:
246246
Enabled: true
247+
Exclude:
248+
- 'features/*'
247249
# NamePrefix: is_
248250
NamePrefixBlacklist: is_
251+
NameWhitelist: has_n_stars
249252

250253
# Offense count: 58
251254
# Cop supports --auto-correct.

lib/gitlab/prometheus/queries/matched_metrics_query.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ def active_series_lookup(metric_groups)
4242

4343
lookup = series.each_slice(MAX_QUERY_ITEMS).flat_map do |batched_series|
4444
client_series(*batched_series, start: timeframe_start, stop: timeframe_end)
45-
.select(&method(:has_matching_label))
45+
.select(&method(:has_matching_label?))
4646
.map { |series_info| [series_info['__name__'], true] }
4747
end
4848
lookup.to_h
4949
end
5050

51-
def has_matching_label(series_info)
51+
def has_matching_label?(series_info)
5252
series_info.key?('environment')
5353
end
5454

0 commit comments

Comments
 (0)