cmake: set warning level to -Wextra (for the main connector code)

Author: rsomla1

CMakeLists.txt

@@ -261,13 +261,12 @@ ADD_SUBDIRECTORY(include)
 INCLUDE_DIRECTORIES(include)
 
 #
-# Set higher warning level on Windows to catch non-portable
-# code.
+# Set higher warning level for the main connector code.
 #
 
 foreach(LANG C CXX)
 
-IF(WIN32)
+if(WIN32)
 
   # 4127 = conditional expression is constant (needed for do {...} while(false))
   # 4512 = assignment operator could not be generated
@@ -279,7 +278,12 @@ IF(WIN32)
 
   set(CMAKE_${LANG}_FLAGS "${CMAKE_${LANG}_FLAGS} /W4 /wd4512 /wd4127")
 
-ENDIF()
+else()
+
+  set(CMAKE_${LANG}_FLAGS "${CMAKE_${LANG}_FLAGS} -Wextra")
+  set(TEST_COMPILE_FLAGS "-Wno-sign-compare")
+
+endif()
 
 endforeach(LANG)
 

xapi/mysqlx_cc_internal.h

@@ -305,7 +305,7 @@ class Order_by : public cdk::Order_by
 
 
     // Get sort direction for the current instance
-    const Sort_direction::value direction() const { return m_sort_direction; }
+    Sort_direction::value direction() const { return m_sort_direction; }
   };
 
   typedef std::vector<Order_by_item> Order_item_list;