Skip to content

Conversation

@zackharley
Copy link

By removing the round brackets on arrow functions with one input we can improve readability.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jan 11, 2017

It seems to be a matter of a style taste. See, for example, this distinction in the very popular guide: https://github.com/airbnb/javascript#arrows--one-arg-parens

@ryanmcdermott
Copy link
Owner

Hey Zack! Thanks for looking into this issue and bringing your work.

As far as style choices, this is a tough thing. The problem is that these arguments always break down into something like a tabs vs. spaces debate, where there's no obvious winner. I've been approving some readability changes, but almost only when it comes to stuff like inconsistencies in formatting between the rest of the document. If we start changing smaller style things then at some point in the future someone will come in and try to change it back. It's all personal preference at the end of the day!

Please feel free to send more of your PRs. This project has been drastically improved by great developers such as yourself!

@zackharley
Copy link
Author

Thanks for the feedback Ryan! Great work on the whole project.

@ryanmcdermott
Copy link
Owner

Thank you Zack that means a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants