Rename Dns related methods into hostname

Author: slandelle

client/src/main/java/org/asynchttpclient/handler/AsyncHandlerExtensions.java

@@ -29,27 +29,27 @@ public interface AsyncHandlerExtensions {
     // ////////// DNS /////////////////
 
     /**
-     * Notify the callback before DNS resolution
+     * Notify the callback before hostname resolution
      * 
      * @param name the name to be resolved
      */
-    void onDnsResolution(String name);
+    void onHostnameResolutionAttempt(String name);
 
     /**
-     * Notify the callback after DNS resolution was successful.
+     * Notify the callback after hostname resolution was successful.
      * 
      * @param name the name to be resolved
      * @param addresses the resolved addresses
      */
-    void onDnsResolutionSuccess(String name, List<InetSocketAddress> addresses);
+    void onHostnameResolutionSuccess(String name, List<InetSocketAddress> addresses);
 
     /**
-     * Notify the callback after DNS resolution failed.
+     * Notify the callback after hostname resolution failed.
      * 
      * @param name the name to be resolved
      * @param cause the failure cause
      */
-    void onDnsResolutionFailure(String name, Throwable cause);
+    void onHostnameResolutionFailure(String name, Throwable cause);
 
     // ////////////// TCP CONNECT ////////
 

client/src/main/java/org/asynchttpclient/handler/ExtendedAsyncHandler.java

@@ -24,15 +24,15 @@
 public abstract class ExtendedAsyncHandler<T> implements AsyncHandler<T>, AsyncHandlerExtensions {
 
     @Override
-    public void onDnsResolution(String name) {
+    public void onHostnameResolutionAttempt(String name) {
     }
 
     @Override
-    public void onDnsResolutionSuccess(String name, List<InetSocketAddress> addresses) {
+    public void onHostnameResolutionSuccess(String name, List<InetSocketAddress> addresses) {
     }
 
     @Override
-    public void onDnsResolutionFailure(String name, Throwable cause) {
+    public void onHostnameResolutionFailure(String name, Throwable cause) {
     }
 
     @Override

client/src/main/java/org/asynchttpclient/resolver/RequestNameResolver.java

@@ -58,30 +58,32 @@ public Future<List<InetSocketAddress>> resolve(Request request, ProxyServer prox
         }
 
         if (asyncHandlerExtensions != null)
-            asyncHandlerExtensions.onDnsResolution(name);
+            asyncHandlerExtensions.onHostnameResolutionAttempt(name);
 
         final Future<List<InetSocketAddress>> whenResolved = request.getNameResolver().resolve(name, port);
 
         if (asyncHandlerExtensions == null)
             return whenResolved;
 
-        Promise<List<InetSocketAddress>> promise = ImmediateEventExecutor.INSTANCE.newPromise();
-
-        whenResolved.addListener(new SimpleGenericFutureListener<List<InetSocketAddress>>() {
-
-            @Override
-            protected void onSuccess(List<InetSocketAddress> addresses) throws Exception {
-                asyncHandlerExtensions.onDnsResolutionSuccess(name, addresses);
-                promise.setSuccess(addresses);
-            }
-
-            @Override
-            protected void onFailure(Throwable t) throws Exception {
-                asyncHandlerExtensions.onDnsResolutionFailure(name, t);
-                promise.setFailure(t);
-            }
-        });
-
-        return promise;
+        else {
+            Promise<List<InetSocketAddress>> promise = ImmediateEventExecutor.INSTANCE.newPromise();
+            
+            whenResolved.addListener(new SimpleGenericFutureListener<List<InetSocketAddress>>() {
+                
+                @Override
+                protected void onSuccess(List<InetSocketAddress> addresses) throws Exception {
+                    asyncHandlerExtensions.onHostnameResolutionSuccess(name, addresses);
+                    promise.setSuccess(addresses);
+                }
+                
+                @Override
+                protected void onFailure(Throwable t) throws Exception {
+                    asyncHandlerExtensions.onHostnameResolutionFailure(name, t);
+                    promise.setFailure(t);
+                }
+            });
+            
+            return promise;
+        }
     }
 }

client/src/test/java/org/asynchttpclient/BasicHttpTest.java

@@ -1396,8 +1396,8 @@ public void testNewConnectionEventsFired() throws Exception {
 
             Object[] expectedEvents = new Object[] {//
             CONNECTION_POOL_EVENT,//
-                    DNS_RESOLUTION_EVENT,//
-                    DNS_RESOLUTION_SUCCESS_EVENT,//
+                    HOSTNAME_RESOLUTION_EVENT,//
+                    HOSTNAME_RESOLUTION_SUCCESS_EVENT,//
                     CONNECTION_OPEN_EVENT,//
                     CONNECTION_SUCCESS_EVENT,//
                     REQUEST_SEND_EVENT,//

client/src/test/java/org/asynchttpclient/BasicHttpsTest.java

@@ -138,8 +138,8 @@ public void testNormalEventsFired() throws Exception {
 
             Object[] expectedEvents = new Object[] { //
             CONNECTION_POOL_EVENT,//
-                    DNS_RESOLUTION_EVENT,//
-                    DNS_RESOLUTION_SUCCESS_EVENT,//
+                    HOSTNAME_RESOLUTION_EVENT,//
+                    HOSTNAME_RESOLUTION_SUCCESS_EVENT,//
                     CONNECTION_OPEN_EVENT,//
                     CONNECTION_SUCCESS_EVENT,//
                     TLS_HANDSHAKE_EVENT,//

client/src/test/java/org/asynchttpclient/netty/handler/NettyReactiveStreamsTest.java

@@ -127,11 +127,11 @@ public ReplayedSimpleAsyncHandler(CountDownLatch replaying, SimpleSubscriber<Htt
             this.replaying = replaying;
         }
         @Override
-        public void onDnsResolution(String name) {}
+        public void onHostnameResolutionAttempt(String name) {}
         @Override
-        public void onDnsResolutionSuccess(String name, List<InetSocketAddress> addresses) {}
+        public void onHostnameResolutionSuccess(String name, List<InetSocketAddress> addresses) {}
         @Override
-        public void onDnsResolutionFailure(String name, Throwable cause) {}
+        public void onHostnameResolutionFailure(String name, Throwable cause) {}
         @Override
         public void onTcpConnect(InetSocketAddress address) {}
         @Override

client/src/test/java/org/asynchttpclient/test/EventCollectingHandler.java

@@ -37,9 +37,9 @@ public class EventCollectingHandler extends AsyncCompletionHandlerBase implement
     public static final String HEADERS_WRITTEN_EVENT = "HeadersWritten";
     public static final String CONTENT_WRITTEN_EVENT = "ContentWritten";
     public static final String CONNECTION_OPEN_EVENT = "ConnectionOpen";
-    public static final String DNS_RESOLUTION_EVENT = "DnsResolution";
-    public static final String DNS_RESOLUTION_SUCCESS_EVENT = "DnsResolutionSuccess";
-    public static final String DNS_RESOLUTION_FAILURE_EVENT = "DnsResolutionFailure";
+    public static final String HOSTNAME_RESOLUTION_EVENT = "HostnameResolution";
+    public static final String HOSTNAME_RESOLUTION_SUCCESS_EVENT = "HostnameResolutionSuccess";
+    public static final String HOSTNAME_RESOLUTION_FAILURE_EVENT = "HostnameResolutionFailure";
     public static final String CONNECTION_SUCCESS_EVENT = "ConnectionSuccess";
     public static final String CONNECTION_FAILURE_EVENT = "ConnectionFailure";
     public static final String TLS_HANDSHAKE_EVENT = "TlsHandshake";
@@ -110,18 +110,18 @@ public void onTcpConnectFailure(InetSocketAddress address, Throwable t) {
     }
 
     @Override
-    public void onDnsResolution(String name) {
-        firedEvents.add(DNS_RESOLUTION_EVENT);
+    public void onHostnameResolutionAttempt(String name) {
+        firedEvents.add(HOSTNAME_RESOLUTION_EVENT);
     }
 
     @Override
-    public void onDnsResolutionSuccess(String name, List<InetSocketAddress> addresses) {
-        firedEvents.add(DNS_RESOLUTION_SUCCESS_EVENT);
+    public void onHostnameResolutionSuccess(String name, List<InetSocketAddress> addresses) {
+        firedEvents.add(HOSTNAME_RESOLUTION_SUCCESS_EVENT);
     }
 
     @Override
-    public void onDnsResolutionFailure(String name, Throwable cause) {
-        firedEvents.add(DNS_RESOLUTION_FAILURE_EVENT);
+    public void onHostnameResolutionFailure(String name, Throwable cause) {
+        firedEvents.add(HOSTNAME_RESOLUTION_FAILURE_EVENT);
     }
 
     @Override