Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AsyncHttpClient/async-http-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: samridh90/async-http-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 9 files changed
  • 1 contributor

Commits on Oct 26, 2018

  1. 857 Support multipart files using InputStream from source file

    @puresam
    puresam committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    049ee8d View commit details
    Browse the repository at this point in the history

  2. Added explicit constructor for -1 contentLength 

    - Added tests for all combinations of known/unknown contentLength and enabled/disabled zeroCopy for `InputStreamPart`
- Fixed how `length()` is computed for `MultipartPart` - returns -1 if contentLength < 0
- Added condition in `NettyBodyBody` to use `BodyChunkedBody` for "zeroCopy" of `RandomAccessBody` if contentLength is -1
    @puresam
    puresam committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    1a6c522 View commit details
    Browse the repository at this point in the history

  3. Add unknown-content-length coverage for large file uploads using Inpu… 

    …tStreamPart
    @puresam
    puresam committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    806670f View commit details
    Browse the repository at this point in the history

  4. Remove zero-copy implementation for InputStreamPart 

    - Fix tests, add additional tests to cover various combinations
    @puresam
    puresam committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    7ab6f45 View commit details
    Browse the repository at this point in the history

  5. Update README.md to document lack of support for zero-copy with Input… 

    …StreamPart
    @puresam
    puresam committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    0a1e490 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2018

  1. Revert "Update README.md to document lack of support for zero-copy wi… 

    …th InputStreamPart"

This reverts commit 0a1e490.
    @puresam
    puresam committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    db29e79 View commit details
    Browse the repository at this point in the history

  2. Revert "Remove zero-copy implementation for InputStreamPart" 

    This reverts commit 7ab6f45.
    @puresam
    puresam committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    7f5c687 View commit details
    Browse the repository at this point in the history

  3. Use BodyChunkedInput in contentLength < 0 in NettyBodyBody

    @puresam
    puresam committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    ec1f32f View commit details
    Browse the repository at this point in the history

  4. Add license header to new files

    @puresam
    puresam committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    28b3cf8 View commit details
    Browse the repository at this point in the history
Loading