Skip to content

Commit 4084725

Browse files
committed
Removed unecessary comments in variant.cpp, Corrected include guard name in variant.h
1 parent bce2b26 commit 4084725

File tree

5 files changed

+6
-16
lines changed

5 files changed

+6
-16
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,4 @@ script:
3535
- buildExampleSketch sandeepmistry:nRF5:TinyBLE 01.Basics Blink
3636
- buildExampleSketch sandeepmistry:nRF5:bluey 01.Basics Blink
3737
- buildExampleSketch sandeepmistry:nRF5:hackaBLE 01.Basics Blink
38+
- buildExampleSketch sandeepmistry:nRF5:Sinobit 01.Basics BareMinimum

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Does not require a custom bootloader on the device.
3333
* [Waveshare BLE400](http://www.waveshare.com/wiki/BLE400)
3434
* [ng-beacon](https://github.com/urish/ng-beacon)
3535
* [TinyBLE](https://www.seeedstudio.com/Seeed-Tiny-BLE-BLE-%2B-6DOF-Mbed-Platform-p-2268.html)
36-
36+
* [Sino:bit](http://sinobit.org)
3737
## Installing
3838

3939
### Board Manager

boards.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -838,7 +838,7 @@ Sinobit.bootloader.tool=sandeepmistry:openocd
838838

839839
Sinobit.build.mcu=cortex-m0
840840
Sinobit.build.f_cpu=16000000
841-
Sinobit.build.board=BBC_MICROBIT
841+
Sinobit.build.board=SINOBIT
842842
Sinobit.build.core=nRF5
843843
Sinobit.build.variant=Sinobit
844844
Sinobit.build.variant_system_lib=

variants/Sinobit/variant.cpp

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,49 +20,38 @@
2020
#include "variant.h"
2121

2222
const uint32_t g_ADigitalPinMap[] = {
23-
// 0 - 4
23+
2424
3, // A0 - left pad
2525
2, // A1 - middle pad
2626
1, // A2 - right pad
2727
4, // A3 - COL1
2828
5, // A4 - COL2
29-
30-
// 5 - 9
3129
17, // BTN A
3230
12, // COL9
3331
11, // COL8
3432
18,
3533
10, // COL7
36-
3734
6, // A5 - COL3
38-
3935
26, // BTN B
4036
20,
4137
23, // SCK
4238
22, // MISO
4339
21, // MOSI
4440
16,
45-
46-
// 17 + 18
4741
(uint32_t)-1, // 3.3V
4842
(uint32_t)-1, // 3.3V
49-
5043
0, // SCL
5144
30, // SDA
52-
5345
25, // RX
5446
24, // TX
55-
5647
7, // COL4
5748
8, // COL5
5849
9, // COL6
5950
13, // ROW1
6051
14, // ROW2
6152
15, // ROW3
62-
6353
28, // ACCEL INT 1
6454
27, // ACCEL INT 2
6555
29, // MAG INT 2
66-
6756
19 // RST
6857
};

variants/Sinobit/variant.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
1515
*/
1616

17-
#ifndef _VARIANT_BBC_MICROBIT_
18-
#define _VARIANT_BBC_MICROBIT_
17+
#ifndef _VARIANT_SINOBIT_
18+
#define _VARIANT_SINOBIT_
1919

2020
/** Master clock frequency */
2121
#define VARIANT_MCK (16000000ul)

0 commit comments

Comments
 (0)