Skip to content

Commit db2fef4

Browse files
author
vrana
committed
Don't display "Foul Magicks" in Maniphest
Summary: There was a typo: `PHID-!!!!-NO_PROJECT` instead of `PHID-!!!!-NO-PROJECT` Also use `<em>` to differentiate from project named "(No Project)". Test Plan: /maniphest/report/project/ Click on (No Project). Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2167
1 parent aa0d039 commit db2fef4

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/applications/maniphest/controller/report/ManiphestReportController.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -424,15 +424,15 @@ public function renderOpenTasks() {
424424
$leftover_closed = idx($result_closed, '', array());
425425
unset($result_closed['']);
426426

427+
$base_link = '/maniphest/?users=';
427428
$leftover_name = phutil_render_tag(
428429
'a',
429430
array(
430-
'href' => '/maniphest/?users=PHID-!!!!-UP-FOR-GRABS',
431+
'href' => $base_link.ManiphestTaskOwner::OWNER_UP_FOR_GRABS,
431432
),
432-
'(Up For Grabs)');
433+
'<em>(Up For Grabs)</em>');
433434
$col_header = 'User';
434435
$header = 'Open Tasks by User and Priority ('.$date.')';
435-
$base_link = '/maniphest/?users=';
436436
break;
437437
case 'project':
438438
$result = array();
@@ -461,15 +461,15 @@ public function renderOpenTasks() {
461461
}
462462
}
463463

464+
$base_link = '/maniphest/view/all/?projects=';
464465
$leftover_name = phutil_render_tag(
465466
'a',
466467
array(
467-
'href' => '/maniphest/view/all/?projects=PHID-!!!!-NO_PROJECT',
468+
'href' => $base_link.ManiphestTaskOwner::PROJECT_NO_PROJECT,
468469
),
469-
'(No Project)');
470+
'<em>(No Project)</em>');
470471
$col_header = 'Project';
471472
$header = 'Open Tasks by Project and Priority ('.$date.')';
472-
$base_link = '/maniphest/view/all/?projects=';
473473
break;
474474
}
475475

src/applications/maniphest/controller/report/__init__.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
phutil_require_module('phabricator', 'aphront/response/404');
1010
phutil_require_module('phabricator', 'aphront/response/redirect');
11+
phutil_require_module('phabricator', 'applications/maniphest/constants/owner');
1112
phutil_require_module('phabricator', 'applications/maniphest/constants/priority');
1213
phutil_require_module('phabricator', 'applications/maniphest/constants/status');
1314
phutil_require_module('phabricator', 'applications/maniphest/constants/transactiontype');

0 commit comments

Comments
 (0)