Skip to content

Commit ecb36d2

Browse files
Mirko Vogtdpgeorge
authored andcommitted
esp32/modnetwork: Re-enable PPP support for IDF-SDK >=v4.
PPP support was disabled in 96008ff - marked as "unsupported" due to an early IDF v4 release. With the currently supported IDF v4.x version - 4c81978 - it appears to be working just fine.
1 parent 52d6eeb commit ecb36d2

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

ports/esp32/modnetwork.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -755,8 +755,8 @@ STATIC const mp_rom_map_elem_t mp_module_network_globals_table[] = {
755755
{ MP_ROM_QSTR(MP_QSTR_WLAN), MP_ROM_PTR(&get_wlan_obj) },
756756
#if !MICROPY_ESP_IDF_4
757757
{ MP_ROM_QSTR(MP_QSTR_LAN), MP_ROM_PTR(&get_lan_obj) },
758-
{ MP_ROM_QSTR(MP_QSTR_PPP), MP_ROM_PTR(&ppp_make_new_obj) },
759758
#endif
759+
{ MP_ROM_QSTR(MP_QSTR_PPP), MP_ROM_PTR(&ppp_make_new_obj) },
760760
{ MP_ROM_QSTR(MP_QSTR_phy_mode), MP_ROM_PTR(&esp_phy_mode_obj) },
761761

762762
#if MODNETWORK_INCLUDE_CONSTANTS

ports/esp32/network_ppp.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
* THE SOFTWARE.
2727
*/
2828

29-
#if !MICROPY_ESP_IDF_4
3029
#include "py/runtime.h"
3130
#include "py/mphal.h"
3231
#include "py/objtype.h"
@@ -284,5 +283,3 @@ const mp_obj_type_t ppp_if_type = {
284283
.name = MP_QSTR_PPP,
285284
.locals_dict = (mp_obj_dict_t *)&ppp_if_locals_dict,
286285
};
287-
288-
#endif // !MICROPY_ESP_IDF_4

0 commit comments

Comments
 (0)