Skip to content

Commit 0edf016

Browse files
sebastianbergmannsebastianbergmann
committed
Merge pull request sebastianbergmann#199 from theseer/master
Fix scroll behavior for tables in dashboard
2 parents 577fdf3 + dec6f34 commit 0edf016

File tree

2 files changed

+54
-40
lines changed

2 files changed

+54
-40
lines changed

‎PHP/CodeCoverage/Report/HTML/Renderer/Template/css/style.css‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,3 +106,9 @@ svg text {
106106
color: #666;
107107
fill: #666;
108108
}
109+
110+
.scrollbox {
111+
height:245px;
112+
overflow-x:hidden;
113+
overflow-y:scroll;
114+
}

‎PHP/CodeCoverage/Report/HTML/Renderer/Template/dashboard.html.dist‎

Lines changed: 48 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -47,31 +47,35 @@
4747
<div class="row">
4848
<div class="col-md-6" style="height: 300px; overflow: auto;">
4949
<h3>Insufficient Coverage</h3>
50-
<table class="table">
51-
<thead>
52-
<tr>
53-
<th><div align="left">Class</div></th>
54-
<th><div align="right">Coverage</div></th>
55-
</tr>
56-
</thead>
57-
<tbody>
50+
<div class="scrollbox">
51+
<table class="table">
52+
<thead>
53+
<tr>
54+
<th><div align="left">Class</div></th>
55+
<th><div align="right">Coverage</div></th>
56+
</tr>
57+
</thead>
58+
<tbody>
5859
{insufficient_coverage_classes}
59-
</tbody>
60-
</table>
60+
</tbody>
61+
</table>
62+
</div>
6163
</div>
6264
<div class="col-md-6" style="height: 300px; overflow: auto;">
6365
<h3>Project Risks</h3>
64-
<table class="table">
65-
<thead>
66-
<tr>
67-
<th><div align="left">Class</div></th>
68-
<th><div align="right"><abbr title="Change Risk Anti-Patterns (CRAP) Index">CRAP</abbr></div></th>
69-
</tr>
70-
</thead>
71-
<tbody>
66+
<div class="scrollbox">
67+
<table class="table">
68+
<thead>
69+
<tr>
70+
<th><div align="left">Class</div></th>
71+
<th><div align="right"><abbr title="Change Risk Anti-Patterns (CRAP) Index">CRAP</abbr></div></th>
72+
</tr>
73+
</thead>
74+
<tbody>
7275
{project_risks_classes}
73-
</tbody>
74-
</table>
76+
</tbody>
77+
</table>
78+
</div>
7579
</div>
7680
</div>
7781
<div class="row">
@@ -96,31 +100,35 @@
96100
<div class="row">
97101
<div class="col-md-6" style="height: 300px; overflow: auto;">
98102
<h3>Insufficient Coverage</h3>
99-
<table class="table">
100-
<thead>
101-
<tr>
102-
<th><div align="left">Method</div></th>
103-
<th><div align="right">Coverage</div></th>
104-
</tr>
105-
</thead>
106-
<tbody>
103+
<div class="scrollbox">
104+
<table class="table">
105+
<thead>
106+
<tr>
107+
<th><div align="left">Method</div></th>
108+
<th><div align="right">Coverage</div></th>
109+
</tr>
110+
</thead>
111+
<tbody>
107112
{insufficient_coverage_methods}
108-
</tbody>
109-
</table>
113+
</tbody>
114+
</table>
115+
</div>
110116
</div>
111117
<div class="col-md-6" style="height: 300px; overflow: auto;">
112118
<h3>Project Risks</h3>
113-
<table class="table">
114-
<thead>
115-
<tr>
116-
<th><div align="left">Method</div></th>
117-
<th><div align="right"><abbr title="Change Risk Anti-Patterns (CRAP) Index">CRAP</abbr></div></th>
118-
</tr>
119-
</thead>
120-
<tbody>
119+
<div class="scrollbox">
120+
<table class="table">
121+
<thead>
122+
<tr>
123+
<th><div align="left">Method</div></th>
124+
<th><div align="right"><abbr title="Change Risk Anti-Patterns (CRAP) Index">CRAP</abbr></div></th>
125+
</tr>
126+
</thead>
127+
<tbody>
121128
{project_risks_methods}
122-
</tbody>
123-
</table>
129+
</tbody>
130+
</table>
131+
</div>
124132
</div>
125133
</div>
126134
<footer>

0 commit comments

Comments
 (0)