Skip to content

Commit 5fda247

Browse files
committed
Merge pull request open-source-parsers#79 from ya1gaurav/patch-2
Remove gcc compilation warnings in json_reader.cpp
2 parents 3e3a8d5 + 767713b commit 5fda247

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/lib_json/json_reader.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -831,8 +831,9 @@ std::vector<Reader::StructuredError> Reader::getStructuredErrors() const {
831831
}
832832

833833
bool Reader::pushError(const Value& value, const std::string& message) {
834-
if(value.getOffsetStart() > end_ - begin_
835-
|| value.getOffsetLimit() > end_ - begin_)
834+
size_t length = end_ - begin_;
835+
if(value.getOffsetStart() > length
836+
|| value.getOffsetLimit() > length)
836837
return false;
837838
Token token;
838839
token.type_ = tokenError;
@@ -847,9 +848,10 @@ bool Reader::pushError(const Value& value, const std::string& message) {
847848
}
848849

849850
bool Reader::pushError(const Value& value, const std::string& message, const Value& extra) {
850-
if(value.getOffsetStart() > end_ - begin_
851-
|| value.getOffsetLimit() > end_ - begin_
852-
|| extra.getOffsetLimit() > end_ - begin_)
851+
size_t length = end_ - begin_;
852+
if(value.getOffsetStart() > length
853+
|| value.getOffsetLimit() > length
854+
|| extra.getOffsetLimit() > length)
853855
return false;
854856
Token token;
855857
token.type_ = tokenError;

0 commit comments

Comments
 (0)