Fix code style

Author: typicode

bin/index.js

@@ -33,12 +33,12 @@ var argv = yargs
   .argv
 
 // Start server function
-function start(object, filename) {
+function start (object, filename) {
   var port = process.env.PORT || argv.port
   var hostname = argv.host === '0.0.0.0' ? 'localhost' : argv.host
 
   for (var prop in object) {
-    console.log(chalk.gray('  http://' + hostname +  ':' + port + '/') + chalk.cyan(prop))
+    console.log(chalk.gray('  http://' + hostname + ':' + port + '/') + chalk.cyan(prop))
   }
 
   console.log(
@@ -59,10 +59,11 @@ function start(object, filename) {
     }
   })
 
+  var router
   if (filename) {
-    var router = jsonServer.router(filename)
+    router = jsonServer.router(filename)
   } else {
-    var router = jsonServer.router(object)
+    router = jsonServer.router(object)
   }
 
   var server = jsonServer.create()
@@ -90,7 +91,7 @@ if (/\.js$/.test(source)) {
 }
 
 if (/^http/.test(source)) {
-  got(source, function(err, data) {
+  got(source, function (err, data) {
     if (err) throw err
     var object = JSON.parse(data)
     start(object)

package.json

@@ -27,10 +27,11 @@
   "devDependencies": {
     "husky": "^0.6.1",
     "mocha": "^2.2.4",
+    "standard": "^3.8.0",
     "supertest": "~0.8.1"
   },
   "scripts": {
-    "test": "mocha -R spec test",
+    "test": "standard && mocha -R spec test",
     "start": "node bin",
     "prepush": "npm t"
   },

src/defaults.js

@@ -8,14 +8,14 @@ var arr = []
 
 // Logger
 arr.push(logger('dev', {
-  skip: function(req, res) { return req.path === '/favicon.ico' }
+  skip: function (req, res) { return req.path === '/favicon.ico' }
 }))
 
 // Serve static files
 if (fs.existsSync(process.cwd() + '/public')) {
-  arr.push(express.static(process.cwd() + '/public'));
+  arr.push(express.static(process.cwd() + '/public'))
 } else {
-  arr.push(express.static(__dirname + '/public'));
+  arr.push(express.static(__dirname + '/public'))
 }
 
 // CORS
@@ -26,4 +26,4 @@ if (process.env.NODE_ENV === 'development') {
   arr.push(errorhandler())
 }
 
-module.exports = arr
+module.exports = arr

src/index.js

@@ -8,4 +8,4 @@ module.exports = {
   },
   defaults: require('./defaults'),
   router: require('./router')
-}
+}

src/router.js

@@ -13,7 +13,7 @@ low.mixin(require('underscore.inflections'))
 // utils.createId can generate incremental id or uuid
 low.mixin({createId: utils.createId})
 
-module.exports = function(source) {
+module.exports = function (source) {
   // Create router
   var router = express.Router()
 
@@ -23,18 +23,19 @@ module.exports = function(source) {
   router.use(methodOverride())
 
   // Create database
+  var db
   if (_.isObject(source)) {
-    var db = low()
+    db = low()
     db.object = source
   } else {
-    var db = low(source)
+    db = low(source)
   }
 
   // Expose database
   router.db = db
 
   // GET /db
-  function showDatabase(req, res, next) {
+  function showDatabase (req, res, next) {
     res.jsonp(db.object)
   }
 
@@ -44,7 +45,7 @@ module.exports = function(source) {
   // GET /:parent/:parentId/:resource?attr=&attr=
   // GET /*?*&_end=
   // GET /*?*&_start=&_end=
-  function list(req, res, next) {
+  function list (req, res, next) {
     // Test if resource exists
     if (!db.object.hasOwnProperty(req.params.resource)) {
       return res.sendStatus(404)
@@ -74,7 +75,7 @@ module.exports = function(source) {
       // Full-text search
       var q = req.query.q.toLowerCase()
 
-      array = db(req.params.resource).filter(function(obj) {
+      array = db(req.params.resource).filter(function (obj) {
         for (var key in obj) {
           var value = obj[key]
           if (_.isString(value) && value.toLowerCase().indexOf(q) !== -1) {
@@ -112,12 +113,12 @@ module.exports = function(source) {
     if (_sort) {
       _order = _order || 'ASC'
 
-      array = _.sortBy(array, function(element) {
-        return element[_sort];
+      array = _.sortBy(array, function (element) {
+        return element[_sort]
       })
 
       if (_order === 'DESC') {
-        array.reverse();
+        array.reverse()
       }
     }
 
@@ -127,20 +128,21 @@ module.exports = function(source) {
       res.setHeader('Access-Control-Expose-Headers', 'X-Total-Count')
     }
 
-    _start = parseInt(_start) || 0
+    _start = parseInt(_start, 10) || 0
 
     if (_end) {
-      array = array.slice(_start, parseInt(_end))
+      _end = parseInt(_end, 10)
+      array = array.slice(_start, _end)
     } else if (_limit) {
-      // Convert strings to int and sum to get end value
-      array = array.slice(_start, parseInt(_start) + parseInt(_limit))
+      _limit = parseInt(_limit, 10)
+      array = array.slice(_start, _start + _limit)
     }
 
     res.jsonp(array)
   }
 
   // GET /:resource/:id
-  function show(req, res, next) {
+  function show (req, res, next) {
     var resource = db(req.params.resource)
       .get(utils.toNative(req.params.id))
 
@@ -152,7 +154,7 @@ module.exports = function(source) {
   }
 
   // POST /:resource
-  function create(req, res, next) {
+  function create (req, res, next) {
     for (var key in req.body) {
       req.body[key] = utils.toNative(req.body[key])
     }
@@ -165,7 +167,7 @@ module.exports = function(source) {
 
   // PUT /:resource/:id
   // PATCH /:resource/:id
-  function update(req, res, next) {
+  function update (req, res, next) {
     for (var key in req.body) {
       req.body[key] = utils.toNative(req.body[key])
     }
@@ -181,13 +183,13 @@ module.exports = function(source) {
   }
 
   // DELETE /:resource/:id
-  function destroy(req, res, next) {
+  function destroy (req, res, next) {
     db(req.params.resource).remove(utils.toNative(req.params.id))
 
     // Remove dependents documents
     var removable = utils.getRemovable(db.object)
 
-    _(removable).each(function(item) {
+    _(removable).each(function (item) {
       db(item.name).remove(item.id)
     })
 

src/utils.js

@@ -7,7 +7,7 @@ _.mixin(_inflections)
 // Example:
 //   'true' -> true
 //   '1' -> 1
-function toNative(value) {
+function toNative (value) {
   if (typeof value === 'string') {
     if (value === '' || value.trim() !== value) {
       return value
@@ -21,11 +21,11 @@ function toNative(value) {
 }
 
 // Return incremented id or uuid
-function createId(coll) {
+function createId (coll) {
   if (_.isEmpty(coll)) {
     return 1
   } else {
-    var id = _.max(coll, function(doc) {
+    var id = _.max(coll, function (doc) {
       return doc.id
     }).id
 
@@ -39,15 +39,14 @@ function createId(coll) {
   }
 }
 
-
 // Returns document ids that have unsatisfied relations
 // Example: a comment that references a post that doesn't exist
-function getRemovable(db) {
+function getRemovable (db) {
   var removable = []
 
-  _(db).each(function(coll, collName) {
-    _(coll).each(function(doc) {
-      _(doc).each(function(value, key) {
+  _(db).each(function (coll, collName) {
+    _(coll).each(function (doc) {
+      _(doc).each(function (value, key) {
         if (/Id$/.test(key)) {
           var refName = _.pluralize(key.slice(0, -2))
           // Test if table exists
@@ -70,4 +69,4 @@ module.exports = {
   toNative: toNative,
   createId: createId,
   getRemovable: getRemovable
-}
+}