Raise memory leak message to error

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/AsyncHttpClient.java

@@ -214,26 +214,25 @@ public AsyncHttpClient(AsyncHttpClientConfig config) {
 
     /**
      * Create a new HTTP Asynchronous Client using a {@link AsyncHttpClientConfig} configuration and
-     * and a {@link AsyncHttpProvider}.
+     * and a AsyncHttpProvider class' name.
      *
-     * @param config       a {@link AsyncHttpClientConfig}
-     * @param httpProvider a {@link AsyncHttpProvider}
+     * @param config        a {@link AsyncHttpClientConfig}
+     * @param providerClass a {@link AsyncHttpProvider}
      */
-    public AsyncHttpClient(AsyncHttpProvider httpProvider, AsyncHttpClientConfig config) {
-        this.config = config;
-        this.httpProvider = httpProvider;
+    public AsyncHttpClient(String providerClass, AsyncHttpClientConfig config) {
+        this(loadProvider(providerClass, config), new AsyncHttpClientConfig.Builder().build());
     }
 
     /**
      * Create a new HTTP Asynchronous Client using a {@link AsyncHttpClientConfig} configuration and
-     * and a AsyncHttpProvider class' name.
+     * and a {@link AsyncHttpProvider}.
      *
-     * @param config        a {@link AsyncHttpClientConfig}
-     * @param providerClass a {@link AsyncHttpProvider}
+     * @param config       a {@link AsyncHttpClientConfig}
+     * @param httpProvider a {@link AsyncHttpProvider}
      */
-    public AsyncHttpClient(String providerClass, AsyncHttpClientConfig config) {
-        this.config = new AsyncHttpClientConfig.Builder().build();
-        this.httpProvider = loadProvider(providerClass, config);
+    public AsyncHttpClient(AsyncHttpProvider httpProvider, AsyncHttpClientConfig config) {
+        this.config = config;
+        this.httpProvider = httpProvider;
     }
 
     public class BoundRequestBuilder extends RequestBuilderBase<BoundRequestBuilder> {
@@ -405,7 +404,7 @@ public void run() {
     protected void finalize() throws Throwable {
         try {
             if (!isClosed.get()) {
-                logger.debug("AsyncHttpClient.close() hasn't been invoked, which may produce file descriptor leaks");
+                logger.error("AsyncHttpClient.close() hasn't been invoked, which may produce file descriptor leaks");
             }
         } finally {
             super.finalize();