Skip to content

Commit bca8f90

Browse files
author
UlricQin
committed
Merge pull request toolkits#3 from ziyel/dev
干掉不必要的for循环
2 parents c50fc9b + f73642a commit bca8f90

File tree

1 file changed

+39
-41
lines changed

1 file changed

+39
-41
lines changed

iostat.go

Lines changed: 39 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -74,60 +74,58 @@ func ListDiskStats() ([]*DiskStats, error) {
7474
}
7575

7676
item := &DiskStats{}
77-
for i := 0; i < size; i++ {
78-
if item.Major, err = strconv.Atoi(fields[0]); err != nil {
79-
return nil, err
80-
}
77+
if item.Major, err = strconv.Atoi(fields[0]); err != nil {
78+
return nil, err
79+
}
8180

82-
if item.Minor, err = strconv.Atoi(fields[1]); err != nil {
83-
return nil, err
84-
}
81+
if item.Minor, err = strconv.Atoi(fields[1]); err != nil {
82+
return nil, err
83+
}
8584

86-
item.Device = fields[2]
85+
item.Device = fields[2]
8786

88-
if item.ReadRequests, err = strconv.ParseUint(fields[3], 10, 64); err != nil {
89-
return nil, err
90-
}
87+
if item.ReadRequests, err = strconv.ParseUint(fields[3], 10, 64); err != nil {
88+
return nil, err
89+
}
9190

92-
if item.ReadMerged, err = strconv.ParseUint(fields[4], 10, 64); err != nil {
93-
return nil, err
94-
}
91+
if item.ReadMerged, err = strconv.ParseUint(fields[4], 10, 64); err != nil {
92+
return nil, err
93+
}
9594

96-
if item.ReadSectors, err = strconv.ParseUint(fields[5], 10, 64); err != nil {
97-
return nil, err
98-
}
95+
if item.ReadSectors, err = strconv.ParseUint(fields[5], 10, 64); err != nil {
96+
return nil, err
97+
}
9998

100-
if item.MsecRead, err = strconv.ParseUint(fields[6], 10, 64); err != nil {
101-
return nil, err
102-
}
99+
if item.MsecRead, err = strconv.ParseUint(fields[6], 10, 64); err != nil {
100+
return nil, err
101+
}
103102

104-
if item.WriteRequests, err = strconv.ParseUint(fields[7], 10, 64); err != nil {
105-
return nil, err
106-
}
103+
if item.WriteRequests, err = strconv.ParseUint(fields[7], 10, 64); err != nil {
104+
return nil, err
105+
}
107106

108-
if item.WriteMerged, err = strconv.ParseUint(fields[8], 10, 64); err != nil {
109-
return nil, err
110-
}
107+
if item.WriteMerged, err = strconv.ParseUint(fields[8], 10, 64); err != nil {
108+
return nil, err
109+
}
111110

112-
if item.WriteSectors, err = strconv.ParseUint(fields[9], 10, 64); err != nil {
113-
return nil, err
114-
}
111+
if item.WriteSectors, err = strconv.ParseUint(fields[9], 10, 64); err != nil {
112+
return nil, err
113+
}
115114

116-
if item.MsecWrite, err = strconv.ParseUint(fields[10], 10, 64); err != nil {
117-
return nil, err
118-
}
115+
if item.MsecWrite, err = strconv.ParseUint(fields[10], 10, 64); err != nil {
116+
return nil, err
117+
}
119118

120-
if item.IosInProgress, err = strconv.ParseUint(fields[11], 10, 64); err != nil {
121-
return nil, err
122-
}
119+
if item.IosInProgress, err = strconv.ParseUint(fields[11], 10, 64); err != nil {
120+
return nil, err
121+
}
123122

124-
if item.MsecTotal, err = strconv.ParseUint(fields[12], 10, 64); err != nil {
125-
return nil, err
126-
}
123+
if item.MsecTotal, err = strconv.ParseUint(fields[12], 10, 64); err != nil {
124+
return nil, err
125+
}
127126

128-
if item.MsecWeightedTotal, err = strconv.ParseUint(fields[13], 10, 64); err != nil {
129-
return nil, err
130-
}
127+
if item.MsecWeightedTotal, err = strconv.ParseUint(fields[13], 10, 64); err != nil {
128+
return nil, err
131129
}
132130

133131
item.TS = time.Now()

0 commit comments

Comments
 (0)