BUG#35755852: Django config raise_on_warnings is ignored without isolation_level

When the Django config option `isolation_level` is not provided, the
value of the option `raise_on_warnings` is ignored.

This issue was fixed by adding the missing default value in the pop()
function used for the `isolation_level`, which raises a `KeyError` and
breaks the assignment of the options.

Change-Id: I54a676b21586b94015618d16c223a60b5871221c

Author: nmariz

CHANGES.txt

@@ -14,6 +14,7 @@ v8.2.0
 - WL#15664: Add support for Python 3.12
 - WL#15623: Improve the authentication module
 - WL#15218: Support WebAuthn authentication
+- BUG#35755852: Django config raise_on_warnings is ignored without isolation_level
 - BUG#35547876: C/Python 8.1.0 type check build fails in the pb2 branch
 - BUG#35544123: Kerberos unit tests configuration is outdated
 - BUG#35503506: Query on information_schema.columns returns bytes

lib/mysql/connector/django/base.py

@@ -373,7 +373,7 @@ def get_connection_params(self) -> Dict[str, Any]:
 
         try:
             options = settings_dict["OPTIONS"].copy()
-            isolation_level = options.pop("isolation_level")
+            isolation_level = options.pop("isolation_level", None)
             if isolation_level:
                 isolation_level = isolation_level.lower()
                 if isolation_level not in self.isolation_levels:

tests/test_django.py

@@ -608,3 +608,22 @@ def test_init_command(self):
             cur.execute(f"SELECT @{self.var_name}")
             res = cur.fetchall()
             self.assertEqual((self.var_value,), res[0])
+
+
+class BugOra35755852(tests.MySQLConnectorTests):
+    """BUG#35755852: Django config raise_on_warnings is ignored without isolation_level
+
+    When the Django config option `isolation_level` is not provided, the
+    value of the option `raise_on_warnings` is ignored.
+
+    This issue was fixed by adding the missing default value in the pop()
+    function used for the `isolation_level`, which raises a `KeyError` and
+    breaks the assignment of the options.
+    """
+
+    def test_missing_config(self):
+        settings.DATABASES["default"]["OPTIONS"] = {"raise_on_warnings": True}
+        cnx = DatabaseWrapper(settings.DATABASES["default"])
+        cnx_params = cnx.get_connection_params()
+        self.assertTrue(cnx_params["raise_on_warnings"])
+        del settings.DATABASES["default"]["OPTIONS"]