BUG#35797406 Add missing question marks to some prompt actions

Some prompt actions contain what are supposed to be questions that
require the user intervention. These have their appropriate description
and are usually precedded by a [y/N] placeholder, which indicates the
possible answers. However, some of these questions do not have a proper
trailing question mark.

This patch adds those missing trailing question marks to the
corresponding prompt actions.

Change-Id: I9caac9df85d1d20fea4d8479fcf70c4f72acb19e

Author: ruiquelhas

gui/extension/CHANGELOG.md

@@ -81,6 +81,7 @@
 - Updated TypeScript MRS SDK and fixed compilation issues
 - BUG#35649509 "mrs.add.db_object()" cannot add schema automatically
 - BUG#35745272 Excessively deep and possibly infinite type instantiation for GEOMETRY values
+- BUG#35797406 Questions that prompt for user action do not have trailing question marks
 
 ## Changes in 1.12.0+8.1.1
 

mrs_plugin/db_objects.py

@@ -294,7 +294,7 @@ def add_db_object(**kwargs):
             if requires_auth is None:
                 if interactive:
                     requires_auth = lib.core.prompt(
-                        "Should the db_object require authentication [y/N]: ",
+                        "Should the db_object require authentication? [y/N]: ",
                         {'defaultValue': 'n'}).strip().lower() == 'y'
                 else:
                     requires_auth = False
@@ -304,7 +304,7 @@ def add_db_object(**kwargs):
                 if interactive:
                     row_user_ownership_enforced = lib.core.prompt(
                         "Should row ownership be required when querying the "
-                        "object [y/N]: ",
+                        "object? [y/N]: ",
                         {'defaultValue': 'n'}).strip().lower() == 'y'
                 else:
                     row_user_ownership_enforced = False
@@ -332,7 +332,7 @@ def add_db_object(**kwargs):
             if items_per_page is None:
                 if interactive:
                     items_per_page = lib.core.prompt(
-                        "How many items should be listed per page "
+                        "How many items should be listed per page? "
                         "[Schema Default]: ",
                         {'defaultValue': "25"}).strip()
                     if items_per_page:

mrs_plugin/docs/index.html

@@ -1238,8 +1238,8 @@ <h4 data-number="4.1.3.2" id="rest-apis"><span
 <span id="cb13-10"><a href="#cb13-10" aria-hidden="true" tabindex="-1"></a></span>
 <span id="cb13-11"><a href="#cb13-11" aria-hidden="true" tabindex="-1"></a><span class="ex">Please</span> enter the name or index of a schema: 4</span>
 <span id="cb13-12"><a href="#cb13-12" aria-hidden="true" tabindex="-1"></a><span class="ex">Please</span> enter the request path for this schema [/sakila]: /sakila</span>
-<span id="cb13-13"><a href="#cb13-13" aria-hidden="true" tabindex="-1"></a><span class="ex">Should</span> the schema require authentication [y/N]:</span>
-<span id="cb13-14"><a href="#cb13-14" aria-hidden="true" tabindex="-1"></a><span class="ex">How</span> many items should be listed per page [Schema Default]:</span>
+<span id="cb13-13"><a href="#cb13-13" aria-hidden="true" tabindex="-1"></a><span class="ex">Should</span> the schema require authentication<span class="pp">?</span> [y/N]:</span>
+<span id="cb13-14"><a href="#cb13-14" aria-hidden="true" tabindex="-1"></a><span class="ex">How</span> many items should be listed per page<span class="pp">?</span> [Schema Default]:</span>
 <span id="cb13-15"><a href="#cb13-15" aria-hidden="true" tabindex="-1"></a><span class="ex">Comments:</span></span>
 <span id="cb13-16"><a href="#cb13-16" aria-hidden="true" tabindex="-1"></a><span class="ex">Options:</span></span>
 <span id="cb13-17"><a href="#cb13-17" aria-hidden="true" tabindex="-1"></a></span>
@@ -1401,9 +1401,9 @@ <h4 data-number="4.1.3.2" id="rest-apis"><span
 <span id="cb17-38"><a href="#cb17-38" aria-hidden="true" tabindex="-1"></a>   <span class="ex">3</span> MEDIA</span>
 <span id="cb17-39"><a href="#cb17-39" aria-hidden="true" tabindex="-1"></a></span>
 <span id="cb17-40"><a href="#cb17-40" aria-hidden="true" tabindex="-1"></a><span class="ex">Please</span> select the CRUD operation format [FEED]:</span>
-<span id="cb17-41"><a href="#cb17-41" aria-hidden="true" tabindex="-1"></a><span class="ex">Should</span> the db_object require authentication [y/N]:</span>
-<span id="cb17-42"><a href="#cb17-42" aria-hidden="true" tabindex="-1"></a><span class="ex">Should</span> row ownership be required when querying the object [y/N]:</span>
-<span id="cb17-43"><a href="#cb17-43" aria-hidden="true" tabindex="-1"></a><span class="ex">How</span> many items should be listed per page [Schema Default]:</span>
+<span id="cb17-41"><a href="#cb17-41" aria-hidden="true" tabindex="-1"></a><span class="ex">Should</span> the db_object require authentication<span class="pp">?</span> [y/N]:</span>
+<span id="cb17-42"><a href="#cb17-42" aria-hidden="true" tabindex="-1"></a><span class="ex">Should</span> row ownership be required when querying the object<span class="pp">?</span> [y/N]:</span>
+<span id="cb17-43"><a href="#cb17-43" aria-hidden="true" tabindex="-1"></a><span class="ex">How</span> many items should be listed per page<span class="pp">?</span> [Schema Default]:</span>
 <span id="cb17-44"><a href="#cb17-44" aria-hidden="true" tabindex="-1"></a><span class="ex">Comments:</span></span>
 <span id="cb17-45"><a href="#cb17-45" aria-hidden="true" tabindex="-1"></a></span>
 <span id="cb17-46"><a href="#cb17-46" aria-hidden="true" tabindex="-1"></a><span class="ex">Object</span> added successfully.</span></code></pre></div>

mrs_plugin/docs/sections/devGuide/AddingRESTServices.md

@@ -194,8 +194,8 @@ When started without parameters, an interactive wizard prompts you for the requi
 
 Please enter the name or index of a schema: 4
 Please enter the request path for this schema [/sakila]: /sakila
-Should the schema require authentication [y/N]:
-How many items should be listed per page [Schema Default]:
+Should the schema require authentication? [y/N]:
+How many items should be listed per page? [Schema Default]:
 Comments:
 Options:
 
@@ -319,9 +319,9 @@ Please select the CRUD operations that should be supported, '*' for all [READ]:
    3 MEDIA
 
 Please select the CRUD operation format [FEED]:
-Should the db_object require authentication [y/N]:
-Should row ownership be required when querying the object [y/N]:
-How many items should be listed per page [Schema Default]:
+Should the db_object require authentication? [y/N]:
+Should row ownership be required when querying the object? [y/N]:
+How many items should be listed per page? [Schema Default]:
 Comments:
 
 Object added successfully.

mrs_plugin/lib/schemas.py

@@ -64,14 +64,14 @@ def prompt_for_request_path(schema_name) -> str:
 
 def prompt_for_requires_auth() -> bool:
     return core.prompt(
-        "Should the schema require authentication [y/N]: ",
+        "Should the schema require authentication? [y/N]: ",
         {'defaultValue': 'n'}).strip().lower() == 'y'
 
 
 def prompt_for_items_per_page() -> int:
     while True:
         result = core.prompt(
-        "How many items should be listed per page [Schema Default]: ",
+        "How many items should be listed per page? [Schema Default]: ",
         {'defaultValue': '25'}).strip()
 
         try: