Undefined index during code coverage merge #619
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/CodeCoverage.php
Owner
|
This branch cannot be rebased due to conflicts. |
Contributor
Author
|
I'll add a new pull request fixing the issue and adding some test cases for this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm terrible sorry, but I just noticed our CI server gave an undefined index on line 406 after pull request #614 . I didn't notice it before because it depends on the order in which the files are merged. Yesterday everything seemed fine, but today the test cases spread differently over multiple processes, which resulted in the undefined index errors.
This pull request should fix the undefined index.