Bug #27672683 CREATE SPATIAL REFERENCE:ASSERTION FAILED: "STANDARD C++

LIBRARIES OUT OF RANGE"

Problem: CREATE SPATIAL REFERENCE SYSTEM with an empty definition string
causes printouts from STL assertions on Windows debug builds because
front() and back() are called on an empty string.

Solution: Use data() and size() instead of front() and back() and make
the invalid/empty string checks in gis::srs::parse_wkt() more robust.

Covered by existing tests in gis.srs. No new testcase needed.

Change-Id: Iebbf7a0b523b098d56a04f0f2db829f52082f2cb

Author: nryeng

sql/dd/impl/types/spatial_reference_system_impl.cc

@@ -171,8 +171,8 @@ bool Spatial_reference_system_impl::deserialize(Sdi_rcontext *rctx,
 bool Spatial_reference_system_impl::parse_definition() {
   gis::srs::Spatial_reference_system *srs = nullptr;
   // parse_wkt() will only allocate memory if successful.
-  if (!gis::srs::parse_wkt(id(), &m_definition.front(),
-                           &m_definition.back() + 1, &srs)) {
+  if (!gis::srs::parse_wkt(id(), m_definition.data(),
+                           m_definition.data() + m_definition.size(), &srs)) {
     m_parsed_definition.reset(srs);
     return false;
   }

sql/gis/srs/srs.cc

@@ -1,4 +1,4 @@
-// Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved.
+// Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved.
 //
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License, version 2.0,
@@ -1043,7 +1043,7 @@ static bool create_projected_srs(gis::srid_t srid,
 
 bool gis::srs::parse_wkt(gis::srid_t srid, const char *begin, const char *end,
                          Spatial_reference_system **result) {
-  if (begin == nullptr || begin == end) {
+  if (begin == nullptr || begin >= (end - 1)) {
     my_error(ER_SRS_PARSE_ERROR, MYF(0), srid);
     return true;
   }

sql/gis/srs/srs.h

@@ -1,7 +1,7 @@
 #ifndef SQL_GIS_SRS_SRS_H_INCLUDED
 #define SQL_GIS_SRS_SRS_H_INCLUDED
 
-// Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved.
+// Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved.
 //
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License, version 2.0,
@@ -1796,7 +1796,7 @@ class Lambert_cylindrical_equal_area_srs : public Projected_srs {
 
   @param[in] srid Spatial reference system ID to use when reporting errors
   @param[in] begin Start of WKT string in UTF-8
-  @param[in] end End of WKT string
+  @param[in] end End of WKT string (one past the last byte)
   @param[out] result Spatial reference system
 
   @retval true An error has occurred

sql/gis/srs/wkt_parser.cc

@@ -1,4 +1,4 @@
-// Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved.
+// Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved.
 //
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License, version 2.0,
@@ -241,7 +241,7 @@ bool gis::srs::wkt_parser::parse_wkt(
     srid_t srid, const char *begin, const char *end,
     gis::srs::wkt_parser::Coordinate_system *cs) {
   // gis::srs::parse_wkt() should have filtered these out already
-  DBUG_ASSERT(begin != nullptr && begin != end);
+  DBUG_ASSERT(begin != nullptr && begin < (end - 1));
 
   namespace wp = gis::srs::wkt_parser;