From 51b5f39e6d6b23119c193c161a4e0500963b759c Mon Sep 17 00:00:00 2001 From: Brie Date: Tue, 21 Apr 2020 12:00:32 -0700 Subject: [PATCH 1/4] Update circle and add mapping - to _ support in props --- .circleci/config.yml | 7 +++---- Segment-Firebase/Classes/SEGFirebaseIntegration.m | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7ae13b6..04facb0 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -12,10 +12,9 @@ jobs: command: | sudo gem install xcpretty sudo gem install cocoapods -v 1.6.1 - # - run: - # name: Fetch Cocoapods specs - # command: curl https://cocoapods-specs.circleci.com/fetch-cocoapods-repo-from-s3.sh | bash -s cf - + - run: + name: Fetch Cocoapods specs + command: curl https://cocoapods-specs.circleci.com/fetch-cocoapods-repo-from-s3.sh | bash -s cf - run: make install - run: make build - run: make test diff --git a/Segment-Firebase/Classes/SEGFirebaseIntegration.m b/Segment-Firebase/Classes/SEGFirebaseIntegration.m index 2787bbf..85db2e1 100644 --- a/Segment-Firebase/Classes/SEGFirebaseIntegration.m +++ b/Segment-Firebase/Classes/SEGFirebaseIntegration.m @@ -176,7 +176,7 @@ + (NSDictionary *)mapToFirebaseParameters:(NSDictionary *)properties withMap:(NS if ([periodSeparatedKey count] > 1) { key = [trimmedKey stringByReplacingOccurrencesOfString:@"." withString:@"_"]; } else { - key = [trimmedKey stringByReplacingOccurrencesOfString:@" " withString:@"_"]; + key = [[trimmedKey stringByReplacingOccurrencesOfString:@" " withString:@"_"] stringByReplacingOccurrencesOfString:@"-" withString:@"_"]; } if ([data isKindOfClass:[NSNumber class]]) { data = [NSNumber numberWithDouble:[data doubleValue]]; From 74e586ba8b861a0b27d8afe2d88d67b32041cc2e Mon Sep 17 00:00:00 2001 From: Brie Date: Tue, 21 Apr 2020 12:03:35 -0700 Subject: [PATCH 2/4] Force new build From 58e38ea8246357e492d9fbd6121d6c5b2e5e378a Mon Sep 17 00:00:00 2001 From: Brie Date: Tue, 21 Apr 2020 12:12:03 -0700 Subject: [PATCH 3/4] Force new build From a205540acf0d619728c53e8ddfa02de68660c141 Mon Sep 17 00:00:00 2001 From: Brie Date: Tue, 21 Apr 2020 12:13:16 -0700 Subject: [PATCH 4/4] Force new build