Skip to content

Commit ff5aac0

Browse files
saqibnsrth
authored andcommitted
Fix "We probably shouldn't recommend autopep8" (scikit-learn#10650)
1 parent d4d768e commit ff5aac0

File tree

2 files changed

+6
-30
lines changed

2 files changed

+6
-30
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -143,25 +143,11 @@ tools:
143143
$ pytest --cov sklearn path/to/tests_for_package
144144
```
145145

146-
- No pyflakes warnings, check with:
146+
- No flake8 warnings, check with:
147147

148148
```bash
149-
$ pip install pyflakes
150-
$ pyflakes path/to/module.py
151-
```
152-
153-
- No PEP8 warnings, check with:
154-
155-
```bash
156-
$ pip install pep8
157-
$ pep8 path/to/module.py
158-
```
159-
160-
- AutoPEP8 can help you fix some of the easy redundant errors:
161-
162-
```bash
163-
$ pip install autopep8
164-
$ autopep8 path/to/pep8.py
149+
$ pip install flake8
150+
$ flake8 path/to/module.py
165151
```
166152

167153
Bonus points for contributions that include a performance analysis with

doc/developers/contributing.rst

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -285,20 +285,10 @@ You can also check for common programming errors with the following tools:
285285

286286
see also :ref:`testing_coverage`
287287

288-
* No pyflakes warnings, check with::
288+
* No flake8 warnings, check with::
289289

290-
$ pip install pyflakes
291-
$ pyflakes path/to/module.py
292-
293-
* No PEP8 warnings, check with::
294-
295-
$ pip install pep8
296-
$ pep8 path/to/module.py
297-
298-
* AutoPEP8 can help you fix some of the easy redundant errors::
299-
300-
$ pip install autopep8
301-
$ autopep8 path/to/pep8.py
290+
$ pip install flake8
291+
$ flake8 path/to/module.py
302292

303293
Bonus points for contributions that include a performance analysis with
304294
a benchmark script and profiling output (please report on the mailing

0 commit comments

Comments
 (0)