Address comments, add tests.

Author: brendandburns

kubernetes/spec/watch_spec.rb

@@ -0,0 +1,36 @@
+# Copyright 2019 The Kubernetes Authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+require 'kubernetes/watch'
+
+describe 'WatchClient' do
+  it 'should construct correctly' do
+    Kubernetes::Watch.new(nil)
+  end
+
+  it 'should parse chunks correctly' do
+    client = Kubernetes::Watch.new(nil)
+    last = ''
+
+    last, data = client.split_lines(last, "foo\nbar\nba")
+
+    expect(last).to eq('ba')
+    expect(data).to eq(%w[foo bar])
+
+    last, data = client.split_lines(last, "z\nblah\n")
+    expect(last).to eq('')
+    expect(data).to eq(%w[baz blah])
+  end
+end

kubernetes/src/kubernetes/watch.rb

@@ -26,14 +26,26 @@ def initialize(client)
     def connect(path, &_block)
       opts = { auth_names: ['BearerToken'] }
       request = @client.build_request('GET', path + '?watch=true', opts)
+      last = ''
       request.on_body do |chunk|
-        parts = chunk.split(/\n/)
-        parts.each do |part|
-          obj = JSON.parse(part)
-          yield obj
+        last, pieces = split_lines(last, chunk)
+        pieces.each do |part|
+          yield JSON.parse(part)
         end
       end
       request.run
     end
+
+    def split_lines(last, chunk)
+      data = chunk
+      data = last + '' + data
+
+      ix = data.rindex("\n")
+      return [data, []] unless ix
+
+      complete = data[0..ix]
+      last = data[(ix + 1)..data.length]
+      [last, complete.split(/\n/)]
+    end
   end
 end