Changes for Netty 4.0 compat

Author: slandelle

netty-bp/codec-dns/src/main/java/io/netty/handler/codec/dns/AbstractDnsMessage.java

@@ -349,19 +349,6 @@ private void clear(int section) {
         }
     }
 
-    @Override
-    public DnsMessage touch() {
-        return (DnsMessage) super.touch();
-    }
-
-    @Override
-    public DnsMessage touch(Object hint) {
-        if (leak != null) {
-            leak.record(hint);
-        }
-        return this;
-    }
-
     @Override
     public DnsMessage retain() {
         return (DnsMessage) super.retain();

netty-bp/codec-dns/src/main/java/io/netty/handler/codec/dns/DatagramDnsQuery.java

@@ -121,16 +121,6 @@ public DatagramDnsQuery clear() {
         return (DatagramDnsQuery) super.clear();
     }
 
-    @Override
-    public DatagramDnsQuery touch() {
-        return (DatagramDnsQuery) super.touch();
-    }
-
-    @Override
-    public DatagramDnsQuery touch(Object hint) {
-        return (DatagramDnsQuery) super.touch(hint);
-    }
-
     @Override
     public DatagramDnsQuery retain() {
         return (DatagramDnsQuery) super.retain();

netty-bp/codec-dns/src/main/java/io/netty/handler/codec/dns/DatagramDnsResponse.java

@@ -155,16 +155,6 @@ public DatagramDnsResponse clear() {
         return (DatagramDnsResponse) super.clear();
     }
 
-    @Override
-    public DatagramDnsResponse touch() {
-        return (DatagramDnsResponse) super.touch();
-    }
-
-    @Override
-    public DatagramDnsResponse touch(Object hint) {
-        return (DatagramDnsResponse) super.touch(hint);
-    }
-
     @Override
     public DatagramDnsResponse retain() {
         return (DatagramDnsResponse) super.retain();

netty-bp/codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsQuery.java

@@ -84,16 +84,6 @@ public DnsQuery clear() {
         return (DnsQuery) super.clear();
     }
 
-    @Override
-    public DnsQuery touch() {
-        return (DnsQuery) super.touch();
-    }
-
-    @Override
-    public DnsQuery touch(Object hint) {
-        return (DnsQuery) super.touch(hint);
-    }
-
     @Override
     public DnsQuery retain() {
         return (DnsQuery) super.retain();

netty-bp/codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRawRecord.java

@@ -102,18 +102,6 @@ public boolean release(int decrement) {
         return content().release(decrement);
     }
 
-    @Override
-    public DnsRawRecord touch() {
-        content().touch();
-        return this;
-    }
-
-    @Override
-    public DnsRawRecord touch(Object hint) {
-        content().touch(hint);
-        return this;
-    }
-
     @Override
     public String toString() {
         final StringBuilder buf = new StringBuilder(64).append(StringUtil.simpleClassName(this)).append('(');

netty-bp/codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsResponse.java

@@ -148,16 +148,6 @@ public DnsResponse clear() {
         return (DnsResponse) super.clear();
     }
 
-    @Override
-    public DnsResponse touch() {
-        return (DnsResponse) super.touch();
-    }
-
-    @Override
-    public DnsResponse touch(Object hint) {
-        return (DnsResponse) super.touch(hint);
-    }
-
     @Override
     public DnsResponse retain() {
         return (DnsResponse) super.retain();

netty-bp/codec-dns/src/main/java/io/netty/handler/codec/dns/DnsMessage.java

@@ -142,12 +142,6 @@ public interface DnsMessage extends ReferenceCounted {
      */
     DnsMessage clear();
 
-    @Override
-    DnsMessage touch();
-
-    @Override
-    DnsMessage touch(Object hint);
-
     @Override
     DnsMessage retain();
 

netty-bp/codec-dns/src/main/java/io/netty/handler/codec/dns/DnsMessageUtil.java

@@ -172,8 +172,8 @@ private static void appendRecords(StringBuilder buf, DnsMessage message, DnsSect
         final int count = message.count(section);
         for (int i = 0; i < count; i ++) {
             buf.append(StringUtil.NEWLINE)
-               .append(StringUtil.TAB)
-               .append(message.recordAt(section, i));
+               .append('\t')
+               .append(message.recordAt(section, i).toString());
         }
     }
 

netty-bp/codec-dns/src/main/java/io/netty/handler/codec/dns/DnsQuery.java

@@ -46,12 +46,6 @@ public interface DnsQuery extends DnsMessage {
     @Override
     DnsQuery clear();
 
-    @Override
-    DnsQuery touch();
-
-    @Override
-    DnsQuery touch(Object hint);
-
     @Override
     DnsQuery retain();
 

netty-bp/codec-dns/src/main/java/io/netty/handler/codec/dns/DnsRawRecord.java

@@ -32,10 +32,4 @@ public interface DnsRawRecord extends DnsRecord, ByteBufHolder {
 
     @Override
     DnsRawRecord retain(int increment);
-
-    @Override
-    DnsRawRecord touch();
-
-    @Override
-    DnsRawRecord touch(Object hint);
 }

netty-bp/codec-dns/src/main/java/io/netty/handler/codec/dns/DnsResponse.java

@@ -99,12 +99,6 @@ public interface DnsResponse extends DnsMessage {
     @Override
     DnsResponse clear();
 
-    @Override
-    DnsResponse touch();
-
-    @Override
-    DnsResponse touch(Object hint);
-
     @Override
     DnsResponse retain();
 

netty-bp/codec-dns/src/test/java/io/netty/handler/codec/dns/DnsQueryTest.java

@@ -59,7 +59,7 @@ public void writeQueryTest() throws Exception {
 
             embedder.writeOutbound(query);
 
-            DatagramPacket packet = embedder.readOutbound();
+            DatagramPacket packet = (DatagramPacket) embedder.readOutbound();
             Assert.assertTrue(packet.content().isReadable());
             packet.release();
             Assert.assertNull(embedder.readOutbound());

netty-bp/codec-dns/src/test/java/io/netty/handler/codec/dns/DnsResponseTest.java

@@ -76,7 +76,7 @@ public void readResponseTest() throws Exception {
         for (byte[] p: packets) {
             ByteBuf packet = embedder.alloc().buffer(512).writeBytes(p);
             embedder.writeInbound(new DatagramPacket(packet, null, new InetSocketAddress(0)));
-            AddressedEnvelope<DnsResponse, InetSocketAddress> envelope = embedder.readInbound();
+            AddressedEnvelope<DnsResponse, InetSocketAddress> envelope = (AddressedEnvelope<DnsResponse, InetSocketAddress>) embedder.readInbound();
             assertThat(envelope, is(instanceOf(DatagramDnsResponse.class)));
             DnsResponse response = envelope.content();
             assertThat(response, is(sameInstance((Object) envelope)));

netty-bp/resolver-dns/src/main/java/io/netty/channel/ReflectiveChannelFactory.java

@@ -0,0 +1,49 @@
+/*
+ * Copyright 2014 The Netty Project
+ *
+ * The Netty Project licenses this file to you under the Apache License,
+ * version 2.0 (the "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at:
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ */
+
+package io.netty.channel;
+
+import io.netty.bootstrap.ChannelFactory;
+import io.netty.util.internal.StringUtil;
+
+/**
+ * A {@link ChannelFactory} that instantiates a new {@link Channel} by invoking its default constructor reflectively.
+ */
+public class ReflectiveChannelFactory<T extends Channel> implements ChannelFactory<T> {
+
+    private final Class<? extends T> clazz;
+
+    public ReflectiveChannelFactory(Class<? extends T> clazz) {
+        if (clazz == null) {
+            throw new NullPointerException("clazz");
+        }
+        this.clazz = clazz;
+    }
+
+    @Override
+    public T newChannel() {
+        try {
+            return clazz.newInstance();
+        } catch (Throwable t) {
+            throw new ChannelException("Unable to create Channel from class " + clazz, t);
+        }
+    }
+
+    @Override
+    public String toString() {
+        return StringUtil.simpleClassName(clazz) + ".class";
+    }
+}