Skip to content

Commit dece6cc

Browse files
committed
minor clean up
1 parent 3f9a596 commit dece6cc

File tree

5 files changed

+8
-10
lines changed

5 files changed

+8
-10
lines changed

client/src/main/java/org/asynchttpclient/netty/SimpleGenericFutureListener.java renamed to client/src/main/java/org/asynchttpclient/netty/SimpleFutureListener.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
package org.asynchttpclient.netty;
1515

1616
import io.netty.util.concurrent.Future;
17-
import io.netty.util.concurrent.GenericFutureListener;
17+
import io.netty.util.concurrent.FutureListener;
1818

19-
public abstract class SimpleGenericFutureListener<V> implements GenericFutureListener<Future<V>> {
19+
public abstract class SimpleFutureListener<V> implements FutureListener<V> {
2020

2121
@Override
2222
public final void operationComplete(Future<V> future) throws Exception {

client/src/main/java/org/asynchttpclient/netty/channel/NettyConnectListener.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import org.asynchttpclient.handler.AsyncHandlerExtensions;
2525
import org.asynchttpclient.netty.NettyResponseFuture;
2626
import org.asynchttpclient.netty.SimpleChannelFutureListener;
27-
import org.asynchttpclient.netty.SimpleGenericFutureListener;
27+
import org.asynchttpclient.netty.SimpleFutureListener;
2828
import org.asynchttpclient.netty.future.StackTraceInspector;
2929
import org.asynchttpclient.netty.request.NettyRequestSender;
3030
import org.asynchttpclient.uri.Uri;
@@ -92,7 +92,7 @@ public void onSuccess(Channel channel) throws Exception {
9292
if (asyncHandlerExtensions != null)
9393
asyncHandlerExtensions.onTlsHandshakeAttempt();
9494

95-
sslHandler.handshakeFuture().addListener(new SimpleGenericFutureListener<Channel>() {
95+
sslHandler.handshakeFuture().addListener(new SimpleFutureListener<Channel>() {
9696

9797
@Override
9898
protected void onSuccess(Channel value) throws Exception {

client/src/main/java/org/asynchttpclient/netty/handler/WebSocketProtocol.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ public UpgradeCallback(NettyResponseFuture<?> future, Channel channel, HttpRespo
8585

8686
@Override
8787
public void call() throws Exception {
88-
89-
9088
boolean validStatus = response.status().equals(SWITCHING_PROTOCOLS);
9189
boolean validUpgrade = response.headers().get(HttpHeaderNames.UPGRADE) != null;
9290
String connection = response.headers().get(HttpHeaderNames.CONNECTION);

client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
import org.asynchttpclient.handler.TransferCompletionHandler;
5454
import org.asynchttpclient.netty.Callback;
5555
import org.asynchttpclient.netty.NettyResponseFuture;
56-
import org.asynchttpclient.netty.SimpleGenericFutureListener;
56+
import org.asynchttpclient.netty.SimpleFutureListener;
5757
import org.asynchttpclient.netty.channel.ChannelManager;
5858
import org.asynchttpclient.netty.channel.ChannelState;
5959
import org.asynchttpclient.netty.channel.Channels;
@@ -277,7 +277,7 @@ private <T> ListenableFuture<T> sendRequestWithNewChannel(//
277277
}
278278

279279
RequestNameResolver.INSTANCE.resolve(request, proxy, asyncHandler)//
280-
.addListener(new SimpleGenericFutureListener<List<InetSocketAddress>>() {
280+
.addListener(new SimpleFutureListener<List<InetSocketAddress>>() {
281281

282282
@Override
283283
protected void onSuccess(List<InetSocketAddress> addresses) {

client/src/main/java/org/asynchttpclient/resolver/RequestNameResolver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import org.asynchttpclient.AsyncHandler;
2626
import org.asynchttpclient.Request;
2727
import org.asynchttpclient.handler.AsyncHandlerExtensions;
28-
import org.asynchttpclient.netty.SimpleGenericFutureListener;
28+
import org.asynchttpclient.netty.SimpleFutureListener;
2929
import org.asynchttpclient.proxy.ProxyServer;
3030
import org.asynchttpclient.uri.Uri;
3131

@@ -68,7 +68,7 @@ public Future<List<InetSocketAddress>> resolve(Request request, ProxyServer prox
6868
else {
6969
Promise<List<InetSocketAddress>> promise = ImmediateEventExecutor.INSTANCE.newPromise();
7070

71-
whenResolved.addListener(new SimpleGenericFutureListener<List<InetSocketAddress>>() {
71+
whenResolved.addListener(new SimpleFutureListener<List<InetSocketAddress>>() {
7272

7373
@Override
7474
protected void onSuccess(List<InetSocketAddress> addresses) throws Exception {

0 commit comments

Comments
 (0)