Skip to content
This repository was archived by the owner on Jul 21, 2023. It is now read-only.

Commit ebb9c26

Browse files
author
Stephane Landelle
committed
Add another public constructor to NettyConnectionsPool that doesn't depend on NettyAsyncHttpProvider, master close AsyncHttpClient#289
1 parent a2e7a14 commit ebb9c26

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

providers/netty/src/main/java/com/ning/http/client/providers/netty/NettyConnectionsPool.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,15 @@ public class NettyConnectionsPool implements ConnectionsPool<String, Channel> {
4444
private final long maxIdleTime;
4545

4646
public NettyConnectionsPool(NettyAsyncHttpProvider provider) {
47-
this.maxTotalConnections = provider.getConfig().getMaxTotalConnections();
48-
this.maxConnectionPerHost = provider.getConfig().getMaxConnectionPerHost();
49-
this.sslConnectionPoolEnabled = provider.getConfig().isSslConnectionPoolEnabled();
50-
this.maxIdleTime = provider.getConfig().getIdleConnectionInPoolTimeoutInMs();
51-
this.maxConnectionLifeTimeInMs = provider.getConfig().getMaxConnectionLifeTimeInMs();
47+
this(provider.getConfig().getMaxTotalConnections(), provider.getConfig().getMaxConnectionPerHost(), provider.getConfig().getIdleConnectionInPoolTimeoutInMs(), provider.getConfig().isSslConnectionPoolEnabled(), provider.getConfig().getMaxConnectionLifeTimeInMs());
48+
}
49+
50+
public NettyConnectionsPool(int maxTotalConnections, int maxConnectionPerHost, long maxIdleTime, boolean sslConnectionPoolEnabled, int maxConnectionLifeTimeInMs) {
51+
this.maxTotalConnections = maxTotalConnections;
52+
this.maxConnectionPerHost = maxConnectionPerHost;
53+
this.sslConnectionPoolEnabled = sslConnectionPoolEnabled;
54+
this.maxIdleTime = maxIdleTime;
55+
this.maxConnectionLifeTimeInMs = maxConnectionLifeTimeInMs;
5256
this.idleConnectionDetector.schedule(new IdleChannelDetector(), maxIdleTime, maxIdleTime);
5357
}
5458

0 commit comments

Comments
 (0)