Skip to content

Commit 0fedae6

Browse files
committed
push fields_for_style? in to a protected method
this way we don't need to call `to_unsafe_h` to get access to ask questions about the underlying hash
1 parent d3ec5c9 commit 0fedae6

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

actionpack/lib/action_controller/metal/strong_parameters.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -540,6 +540,10 @@ def permitted=(new_permitted)
540540
@permitted = new_permitted
541541
end
542542

543+
def fields_for_style?
544+
@parameters.all? { |k, v| k =~ /\A-?\d+\z/ && v.is_a?(Hash) }
545+
end
546+
543547
private
544548
def new_instance_with_inherited_permitted_status(hash)
545549
self.class.new(hash).tap do |new_instance|
@@ -570,7 +574,7 @@ def each_element(object)
570574
when Array
571575
object.grep(Parameters).map { |el| yield el }.compact
572576
when Parameters
573-
if fields_for_style?(object)
577+
if object.fields_for_style?
574578
hash = object.class.new
575579
object.each { |k,v| hash[k] = yield v }
576580
hash
@@ -580,10 +584,6 @@ def each_element(object)
580584
end
581585
end
582586

583-
def fields_for_style?(object)
584-
object.to_unsafe_h.all? { |k, v| k =~ /\A-?\d+\z/ && v.is_a?(Hash) }
585-
end
586-
587587
def unpermitted_parameters!(params)
588588
unpermitted_keys = unpermitted_keys(params)
589589
if unpermitted_keys.any?

0 commit comments

Comments
 (0)