Skip to content

Commit cb3f255

Browse files
committed
remove useless function
Now that the value is cached on the stack, `array_of_permitted_scalars_filter` is exactly the same as `array_of_permitted_scalars?`, so lets just have one
1 parent 2df8e86 commit cb3f255

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

actionpack/lib/action_controller/metal/strong_parameters.rb

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -643,13 +643,7 @@ def permitted_scalar_filter(params, key)
643643
end
644644

645645
def array_of_permitted_scalars?(value)
646-
if value.is_a?(Array)
647-
value.all? {|element| permitted_scalar?(element)}
648-
end
649-
end
650-
651-
def array_of_permitted_scalars_filter(value)
652-
if array_of_permitted_scalars?(value)
646+
if value.is_a?(Array) && value.all? {|element| permitted_scalar?(element)}
653647
yield value
654648
end
655649
end
@@ -665,7 +659,7 @@ def hash_filter(params, filter)
665659

666660
if filter[key] == EMPTY_ARRAY
667661
# Declaration { comment_ids: [] }.
668-
array_of_permitted_scalars_filter(self[key]) do |val|
662+
array_of_permitted_scalars?(self[key]) do |val|
669663
params[key] = val
670664
end
671665
else

0 commit comments

Comments
 (0)