Skip to content

Commit 787d1f9

Browse files
jteplitzmhevery
authored andcommitted
fix(Typings): Remove public exports added in 1926335
Closes angular#4147
1 parent 0246b2a commit 787d1f9

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+944
-869
lines changed

docs/typescript-definition-package/index.js

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -60,27 +60,21 @@ module.exports = new Package('angular-v2-docs', [jsdocPackage, nunjucksPackage,
6060
{
6161
id: 'angular2/router',
6262
references: ['./angular2.d.ts'],
63-
remapTypes: {Type: 'ng.Type'},
63+
remapTypes: {Type: 'ng.Type', InjectableReference: 'ng.InjectableReference'},
6464
modules: {'angular2/router': {namespace: 'ngRouter', id: 'angular2/router'}}
6565
},
6666
{
6767
id: 'angular2/http',
6868
references: ['./angular2.d.ts'],
69-
remapTypes: {Type: 'ng.Type', Observable: 'ng.Observable', EventEmitter: 'ng.EventEmitter'},
69+
remapTypes: {Type: 'ng.Type', Observable: 'ng.Observable', EventEmitter: 'ng.EventEmitter', InjectableReference: 'ng.InjectableReference' },
7070
modules: {'angular2/http': {namespace: 'ngHttp', id: 'angular2/http'}}
7171
},
7272
{
7373
id: 'angular2/test_lib',
7474
references: ['./angular2.d.ts', '../jasmine/jasmine.d.ts'],
75-
remapTypes: {
76-
Type: 'ng.Type',
77-
Binding: 'ng.Binding',
78-
ViewMetadata: 'ng.ViewMetadata',
79-
Injector: 'ng.Injector',
80-
Predicate: 'ng.Predicate',
81-
ElementRef: 'ng.ElementRef',
82-
DebugElement: 'ng.DebugElement'
83-
},
75+
remapTypes: { Type: 'ng.Type', Binding: 'ng.Binding', ViewMetadata: 'ng.ViewMetadata', Injector: 'ng.Injector',
76+
Predicate: 'ng.Predicate', ElementRef: 'ng.ElementRef', DebugElement: 'ng.DebugElement',
77+
InjectableReference: 'ng.InjectableReference' },
8478
modules: {'angular2/test_lib': {namespace: 'ngTestLib', id: 'angular2/test_lib'}}
8579
}
8680
];

modules/angular2/angular2.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export * from './core';
22
export * from './profile';
33
export * from './lifecycle_hooks';
4-
export * from './bootstrap';
4+
export * from './bootstrap';

modules/angular2/core.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,3 @@ export * from './src/core/directives';
1919
export * from './src/core/forms';
2020
export * from './src/core/debug';
2121
export * from './src/core/change_detection';
22-
export {Reflector, ReflectionInfo} from './src/core/reflection/reflection';
23-
export {
24-
PlatformReflectionCapabilities
25-
} from './src/core/reflection/platform_reflection_capabilities';
26-
export {SetterFn, GetterFn, MethodFn} from './src/core/reflection/types';

modules/angular2/http.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ export {BaseRequestOptions, RequestOptions} from './src/http/base_request_option
3030
export {BaseResponseOptions, ResponseOptions} from './src/http/base_response_options';
3131
export {XHRBackend, XHRConnection} from './src/http/backends/xhr_backend';
3232
export {JSONPBackend, JSONPConnection} from './src/http/backends/jsonp_backend';
33-
export {BrowserJsonp} from './src/http/backends/browser_jsonp';
3433
export {Http, Jsonp} from './src/http/http';
3534

3635
export {Headers} from './src/http/headers';

modules/angular2/router.ts

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -7,47 +7,12 @@
77

88
export {Router, RootRouter} from './src/router/router';
99
export {RouterOutlet} from './src/router/router_outlet';
10-
export {
11-
DynamicComponentLoader,
12-
ComponentRef,
13-
ElementRef,
14-
Compiler,
15-
AppViewManager,
16-
ViewRef,
17-
HostViewRef,
18-
ProtoViewRef,
19-
ViewContainerRef,
20-
TemplateRef
21-
} from './core';
22-
export {
23-
Renderer,
24-
RenderElementRef,
25-
RenderViewRef,
26-
RenderProtoViewRef,
27-
RenderEventDispatcher,
28-
RenderFragmentRef,
29-
RenderViewWithFragments
30-
} from './render';
31-
export {
32-
Binding,
33-
Injector,
34-
ResolvedBinding,
35-
Key,
36-
Dependency,
37-
ProtoInjector,
38-
DependencyProvider,
39-
BindingWithVisibility,
40-
Visibility,
41-
ResolvedFactory
42-
} from './src/core/di';
4310
export {RouterLink} from './src/router/router_link';
4411
export {RouteParams} from './src/router/instruction';
4512
export {RouteRegistry} from './src/router/route_registry';
4613
export {LocationStrategy} from './src/router/location_strategy';
4714
export {HashLocationStrategy} from './src/router/hash_location_strategy';
4815
export {PathLocationStrategy} from './src/router/path_location_strategy';
49-
export {PathRecognizer, PathMatch} from './src/router/path_recognizer';
50-
export {RouteHandler} from './src/router/route_handler';
5116
export {Location, APP_BASE_HREF} from './src/router/location';
5217
export {Pipeline} from './src/router/pipeline';
5318
export * from './src/router/route_config_decorator';
@@ -108,8 +73,6 @@ export const ROUTER_BINDINGS: any[] = CONST_EXPR([
10873
}))
10974
]);
11075

111-
export interface InjectableReference {}
112-
11376
function routerFactory(registry, pipeline, location, appRoot) {
11477
return new RootRouter(registry, pipeline, location, appRoot);
11578
}

modules/angular2/src/core/change_detection.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,6 @@ export {
2222
IterableDifferFactory,
2323
KeyValueDiffers,
2424
KeyValueDiffer,
25-
KeyValueDifferFactory,
26-
Lexer,
27-
Parser,
28-
ChangeDispatcher,
29-
BindingTarget,
30-
DirectiveIndex,
31-
DebugContext,
32-
ProtoChangeDetector
33-
} from 'angular2/src/core/change_detection/change_detection';
34-
export * from 'angular2/src/core/change_detection/parser/ast';
25+
KeyValueDifferFactory
26+
27+
} from './change_detection/change_detection';

modules/angular2/src/core/change_detection/change_detection.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,15 @@ import {
1414
import {Injector, Inject, Injectable, OpaqueToken, Optional, Binding} from 'angular2/src/core/di';
1515
import {StringMap, StringMapWrapper} from 'angular2/src/core/facade/collection';
1616
import {CONST, CONST_EXPR, isPresent, assertionsEnabled} from 'angular2/src/core/facade/lang';
17-
export * from './parser/ast';
17+
18+
export {
19+
ASTWithSource,
20+
AST,
21+
AstTransformer,
22+
PropertyRead,
23+
LiteralArray,
24+
ImplicitReceiver
25+
} from './parser/ast';
1826

1927
export {Lexer} from './parser/lexer';
2028
export {Parser} from './parser/parser';

modules/angular2/src/core/compiler.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,4 @@ export {ElementRef} from './compiler/element_ref';
1919
export {TemplateRef} from './compiler/template_ref';
2020
export {ViewRef, HostViewRef, ProtoViewRef} from './compiler/view_ref';
2121
export {ViewContainerRef} from './compiler/view_container_ref';
22-
export {AppView, AppProtoView, AppProtoViewMergeMapping, AppViewContainer} from './compiler/view';
2322
export {ComponentRef} from './compiler/dynamic_component_loader';
24-
export {
25-
ElementInjector,
26-
PreBuiltObjects,
27-
TreeNode,
28-
ProtoElementInjector,
29-
DirectiveBinding,
30-
EventEmitterAccessor
31-
} from './compiler/element_injector';
32-
export {ElementBinder} from './compiler/element_binder';

modules/angular2/src/core/debug/debug_element.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,13 @@ import {ElementRef} from 'angular2/src/core/compiler/element_ref';
1616
export class DebugElement {
1717
_elementInjector: ElementInjector;
1818

19+
/**
20+
* @private
21+
*/
1922
constructor(private _parentView: AppView, private _boundElementIndex: number) {
2023
this._elementInjector = this._parentView.elementInjectors[this._boundElementIndex];
2124
}
2225

23-
static create(elementRef: ElementRef): DebugElement {
24-
return new DebugElement(internalView(elementRef.parentView), elementRef.boundElementIndex);
25-
}
26-
2726
get componentInstance(): any {
2827
if (!isPresent(this._elementInjector)) {
2928
return null;
@@ -144,7 +143,7 @@ export class DebugElement {
144143
* @return {DebugElement}
145144
*/
146145
export function inspectElement(elementRef: ElementRef): DebugElement {
147-
return DebugElement.create(elementRef);
146+
return new DebugElement(internalView(elementRef.parentView), elementRef.boundElementIndex);
148147
}
149148

150149
export function asNativeElements(arr: DebugElement[]): any[] {

modules/angular2/src/core/pipes.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,3 @@ export {LimitToPipe} from './pipes/limit_to_pipe';
1212
export {LowerCasePipe} from './pipes/lowercase_pipe';
1313
export {NumberPipe, DecimalPipe, PercentPipe, CurrencyPipe} from './pipes/number_pipe';
1414
export {UpperCasePipe} from './pipes/uppercase_pipe';
15-
export {ProtoPipes} from './pipes/pipes';
16-
export {PipeBinding} from './pipes/pipe_binding';

0 commit comments

Comments
 (0)