Ensure all files have trailing new-lines and enforce with clang warning

Author: baldurk

CMakeLists.txt

@@ -327,6 +327,10 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
         endif()
     endif()
 
+    if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+        list(APPEND warning_flags -Wnewline-eof)
+    endif()
+
     if(CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.0 AND NOT APPLE)
         list(APPEND warning_flags -Wno-unused-lambda-capture)
     endif()

qrenderdoc/Code/Interface/Analytics.h

@@ -318,4 +318,4 @@ void DocumentReport();
 
 #endif
 
-#endif
+#endif

qrenderdoc/Code/Interface/RemoteHost.h

@@ -132,4 +132,4 @@ Returns the name to display for this host in the UI, either :meth:`FriendlyName`
   void UpdateStatus(ReplayStatus status);
 };
 
-DECLARE_REFLECTION_STRUCT(RemoteHost);
+DECLARE_REFLECTION_STRUCT(RemoteHost);

qrenderdoc/Code/QRDUtils.h

@@ -655,4 +655,4 @@ bool IsDarkTheme();
 float getLuminance(const QColor &col);
 QColor contrastingColor(const QColor &col, const QColor &defaultCol);
 
-void *AccessWaylandPlatformInterface(const QByteArray &resource, QWindow *window);
+void *AccessWaylandPlatformInterface(const QByteArray &resource, QWindow *window);

qrenderdoc/Code/RGPInterop.h

@@ -141,4 +141,4 @@ class RGPInterop : public IRGPInterop
   QString EncodeCommand(RGPCommand command, QVariantList params);
   bool DecodeCommand(QString command);
   void ProcessReadBuffer();
-};
+};

qrenderdoc/Code/Resources.h

@@ -149,4 +149,4 @@ struct Icons
 #define RESOURCE_DEF(name, filename) \
   static const QIcon &name() { return Resources::name().icon; }
   RESOURCE_LIST()
-};
+};

qrenderdoc/Code/precompiled.cpp

@@ -22,4 +22,4 @@
  * THE SOFTWARE.
  ******************************************************************************/
 
-#include "precompiled.h"
+#include "precompiled.h"

qrenderdoc/Code/pyrenderdoc/PythonContext.cpp

@@ -1271,4 +1271,4 @@ extern "C" QWidget *QWidgetFromPy(PyObject *widget)
 extern "C" PyObject *QWidgetToPy(QWidget *widget)
 {
   return PythonContext::QWidgetToPy(widget);
-}
+}

qrenderdoc/Code/pyrenderdoc/PythonContext.h

@@ -181,4 +181,4 @@ struct PythonContextHandle
   PythonContext &ctx() { return *m_ctx; }
 private:
   PythonContext *m_ctx;
-};
+};

qrenderdoc/Code/pyrenderdoc/container_handling.h

@@ -688,4 +688,4 @@ int array_setsubscript(arrayType *thisptr, PyObject *idxobj, PyObject *val)
   SWIG_exception_fail(SWIG_TypeError, "list index not index or slice");
 fail:
   return -1;
-}
+}

qrenderdoc/Code/pyrenderdoc/pyrenderdoc_stub.cpp

@@ -64,4 +64,4 @@ extern "C" void SetThreadBlocking(PyObject *global_handle, bool block)
 {
 }
 
-REPLAY_PROGRAM_MARKER()
+REPLAY_PROGRAM_MARKER()

qrenderdoc/Code/pyrenderdoc/qrenderdoc_stub.cpp

@@ -255,4 +255,4 @@ void RemoteHost::SetConnected(bool connected)
 
 void RemoteHost::SetShutdown()
 {
-}
+}

qrenderdoc/Styles/StyleData.cpp

@@ -51,4 +51,4 @@ const ThemeDescriptor availStyles[] = {
 };
 
 const int numAvailable = sizeof(availStyles) / sizeof(ThemeDescriptor);
-};
+};

qrenderdoc/Styles/StyleData.h

@@ -45,4 +45,4 @@ struct ThemeDescriptor
 
 extern const ThemeDescriptor availStyles[];
 extern const int numAvailable;
-};
+};

qrenderdoc/Widgets/CustomPaintWidget.cpp

@@ -123,4 +123,4 @@ bool CustomPaintWidget::event(QEvent *e)
     paintEvent(NULL);
   return QWidget::event(e);
 }
-#endif
+#endif

qrenderdoc/Widgets/Extended/RDHeaderView.h

@@ -132,4 +132,4 @@ inline int RDHeaderView::logicalIndexAt(int ax, int ay) const
 inline int RDHeaderView::logicalIndexAt(const QPoint &apos) const
 {
   return logicalIndexAt(apos.x(), apos.y());
-}
+}

qrenderdoc/Widgets/Extended/RDTreeWidget.cpp

@@ -1082,4 +1082,4 @@ void RDTreeWidget::endInsertChild(RDTreeWidgetItem *item, int index)
   // work is all done in beginInsertChild
   if(!m_queueUpdates)
     m_model->endInsertChild(item);
-}
+}

qrenderdoc/Widgets/FindReplace.cpp

@@ -192,4 +192,4 @@ void FindReplace::on_findMode_clicked()
 void FindReplace::on_replaceMode_clicked()
 {
   setReplaceMode(true);
-}
+}

qrenderdoc/Widgets/ResourcePreview.cpp

@@ -122,4 +122,4 @@ void ResourcePreview::changeEvent(QEvent *event)
 QWidget *ResourcePreview::thumbWidget()
 {
   return ui->thumbnail;
-}
+}

qrenderdoc/Widgets/ThumbnailStrip.cpp

@@ -172,4 +172,4 @@ void ThumbnailStrip::refreshLayout()
         c->setSize(QSize(avail.width(), aspectHeight));
     }
   }
-}
+}

qrenderdoc/Windows/Dialogs/ExtensionManager.cpp

@@ -238,4 +238,4 @@ void ExtensionManager::update_currentItem(RDTreeWidgetItem *item)
       ui->alwaysLoad->setChecked(m_Ctx.Config().AlwaysLoad_Extensions.contains(e.package));
     }
   }
-}
+}

qrenderdoc/Windows/Dialogs/SettingsDialog.cpp

@@ -980,4 +980,4 @@ void SettingsDialog::on_UIStyle_currentIndexChanged(int index)
   }
 
   m_Ctx.Config().Save();
-}
+}

qrenderdoc/Windows/Dialogs/UpdateDialog.cpp

@@ -260,4 +260,4 @@ void UpdateDialog::on_update_clicked()
 
     });
   }
-}
+}

qrenderdoc/Windows/PipelineState/VulkanPipelineStateViewer.cpp

@@ -3706,4 +3706,4 @@ void VulkanPipelineStateViewer::on_meshView_clicked()
   if(!m_Ctx.HasMeshPreview())
     m_Ctx.ShowMeshPreview();
   ToolWindowManager::raiseToolWindow(m_Ctx.GetMeshPreview()->Widget());
-}
+}

qrenderdoc/Windows/StatisticsViewer.cpp

@@ -842,4 +842,4 @@ void StatisticsViewer::OnCaptureLoaded()
 {
   GenerateReport();
   ui->statistics->setText(m_Report);
-}
+}

qrenderdoc/renderdocui_stub.cpp

@@ -81,4 +81,4 @@ int WINAPI wWinMain(_In_ HINSTANCE hInst, _In_opt_ HINSTANCE hPrevInstance, _In_
   delete[] paramsAlloc;
 
   return 0;
-}
+}

renderdoc/3rdparty/android/android_manifest.h

@@ -248,4 +248,4 @@ struct ResXMLTree_cdataExt
 
   // The typed value of the character data if this is a CDATA node.
   struct Res_value typedData;
-};
+};

renderdoc/3rdparty/catch/catch.hpp

@@ -46,4 +46,4 @@ struct StringMaker<rdcstr>
 {
   static std::string convert(rdcstr const &value) { return value; }
 };
-}
+}

renderdoc/3rdparty/jpeg-compressor/jpgd.cpp

@@ -3172,4 +3172,4 @@ unsigned char *decompress_jpeg_image_from_file(const char *pSrc_filename, int *w
   return decompress_jpeg_image_from_stream(&file_stream, width, height, actual_comps, req_comps);
 }
 
-} // namespace jpgd
+} // namespace jpgd

renderdoc/android/android.cpp

@@ -1168,4 +1168,4 @@ ExecuteResult AndroidRemoteServer::ExecuteAndInject(const char *a, const char *w
 
 AndroidController AndroidController::m_Inst;
 
-DeviceProtocolRegistration androidProtocol("adb", &AndroidController::Get);
+DeviceProtocolRegistration androidProtocol("adb", &AndroidController::Get);

renderdoc/android/android_manifest.cpp

@@ -635,4 +635,4 @@ bool PatchManifest(std::vector<byte> &manifestBytes)
 
   return true;
 }
-};
+};

renderdoc/android/android_utils.h

@@ -72,4 +72,4 @@ std::string GetPathForPackage(const std::string &deviceID, const std::string &pa
 bool PatchManifest(std::vector<byte> &manifest);
 };
 
-DECLARE_REFLECTION_ENUM(Android::ABI);
+DECLARE_REFLECTION_ENUM(Android::ABI);

renderdoc/android/jdwp.h

@@ -568,4 +568,4 @@ class Connection
   std::string GetSignature(referenceTypeID typeID);
   std::vector<Method> GetMethods(referenceTypeID searchClass);
 };
-};
+};

renderdoc/android/jdwp_connection.cpp

@@ -616,4 +616,4 @@ std::vector<Method> Connection::GetMethods(referenceTypeID searchClass)
   data.Done();
   return ret;
 }
-};
+};

renderdoc/android/jdwp_util.cpp

@@ -306,4 +306,4 @@ CommandData &CommandData::Write(const frameID &id)
   WriteBytes(&tmp, frameID::getSize());
   return *this;
 }
-};
+};

renderdoc/api/replay/common_pipestate.h

@@ -426,4 +426,4 @@ no VB bound.
   bool used;
 };
 
-DECLARE_REFLECTION_STRUCT(VertexInputAttribute);
+DECLARE_REFLECTION_STRUCT(VertexInputAttribute);

renderdoc/api/replay/pipestate.h

@@ -341,4 +341,4 @@ For some APIs that don't distinguish by entry point, this may be empty.
   const D3D12Pipe::Shader &GetD3D12Stage(ShaderStage stage) const;
   const GLPipe::Shader &GetGLStage(ShaderStage stage) const;
   const VKPipe::Shader &GetVulkanStage(ShaderStage stage) const;
-};
+};

renderdoc/api/replay/rdcstr.h

@@ -778,4 +778,4 @@ inline rdcstr operator+(const QChar &left, const rdcstr &right)
 {
   return rdcstr(left) += right;
 }
-#endif
+#endif

renderdoc/api/replay/renderdoc_tostr.inl

@@ -1119,4 +1119,4 @@ rdcstr DoStringise(const ShaderStageMask &el)
     STRINGISE_BITFIELD_CLASS_BIT(Compute);
   }
   END_BITFIELD_STRINGISE();
-}
+}

renderdoc/common/globalconfig.h

@@ -219,4 +219,4 @@ enum
 // otherwise, enable them in development builds
 #define ENABLE_UNIT_TESTS RDOC_DEVEL
 
-#endif
+#endif

renderdoc/common/threading_tests.cpp

@@ -71,4 +71,4 @@ TEST_CASE("Test spin lock", "[threading]")
   CHECK(finalValue == value);
 }
 
-#endif    // ENABLED(ENABLE_UNIT_TESTS)
+#endif    // ENABLED(ENABLE_UNIT_TESTS)

renderdoc/core/core.h

@@ -767,4 +767,4 @@ struct DeviceProtocolRegistration
   {
     RenderDoc::Inst().RegisterDeviceProtocol(protocol, handler);
   }
-};
+};

renderdoc/core/intervals_tests.cpp

@@ -440,4 +440,4 @@ TEST_CASE("Test Intervals type", "[intervals]")
   };
 };
 
-#endif    // ENABLED(ENABLE_UNIT_TESTS)
+#endif    // ENABLED(ENABLE_UNIT_TESTS)

renderdoc/core/plugins.cpp

@@ -85,4 +85,4 @@ std::string LocatePluginFile(const std::string &path, const std::string &fileNam
     ret = fileName;
 
   return ret;
-}
+}

renderdoc/core/plugins.h

@@ -24,4 +24,4 @@
 
 #include <string>
 
-std::string LocatePluginFile(const std::string &path, const std::string &fileName);
+std::string LocatePluginFile(const std::string &path, const std::string &fileName);

renderdoc/core/precompiled.cpp

@@ -22,4 +22,4 @@
  * THE SOFTWARE.
  ******************************************************************************/
 
-#include "precompiled.h"
+#include "precompiled.h"

renderdoc/core/precompiled.h

@@ -26,4 +26,4 @@
 
 #include "api/app/renderdoc_app.h"
 #include "api/replay/renderdoc_replay.h"
-#include "common/common.h"
+#include "common/common.h"

renderdoc/data/glsl/glsl_globals.h

@@ -173,4 +173,4 @@ vec3 CalcCubeCoord(vec2 uv, int face)
 #define MESH_TRIANGLE_STRIP 2u
 #define MESH_TRIANGLE_FAN 3u
 #define MESH_TRIANGLE_LIST_ADJ 4u
-#define MESH_TRIANGLE_STRIP_ADJ 5u
+#define MESH_TRIANGLE_STRIP_ADJ 5u

renderdoc/data/glsl/glsl_ubos_cpp.h

@@ -50,4 +50,4 @@
 #error Only one of VULKAN and OPENGL must be defined in glsl_ubos.h
 #endif
 
-#include "glsl_ubos.h"
+#include "glsl_ubos.h"

renderdoc/data/glsl_shaders.cpp

@@ -1853,4 +1853,4 @@ void main() {
   };
 }
 
-#endif
+#endif

renderdoc/data/glsl_shaders.h

@@ -44,4 +44,4 @@ enum class ShaderStage : uint32_t;
 using ReflectionMaker =
     std::function<void(ShaderStage stage, const std::string &source, const std::string &entryPoint,
                        ShaderReflection &refl, ShaderBindpointMapping &mapping)>;
-void TestGLSLReflection(ShaderType testType, ReflectionMaker compile);
+void TestGLSLReflection(ShaderType testType, ReflectionMaker compile);

renderdoc/data/hlsl/hlsl_cbuffers.h

@@ -217,4 +217,4 @@ cbuffer HistogramCBufferData REG(b0)
 #define MESH_TRIANGLE_LIST 1
 #define MESH_TRIANGLE_STRIP 2
 #define MESH_TRIANGLE_LIST_ADJ 3
-#define MESH_TRIANGLE_STRIP_ADJ 4
+#define MESH_TRIANGLE_STRIP_ADJ 4

renderdoc/driver/d3d11/d3d11_context1_wrap.cpp

@@ -2353,4 +2353,4 @@ TEST_CASE("Check UpdateSubresource data length calculations", "[d3d]")
   }
 }
 
-#endif
+#endif

renderdoc/driver/d3d11/d3d11_context3_wrap.cpp

@@ -70,4 +70,4 @@ HRESULT WrappedID3D11DeviceContext::Wait(ID3D11Fence *pFence, UINT64 Value)
     return E_NOINTERFACE;
 
   return m_pRealContext4->Wait(UNWRAP(WrappedID3D11Fence, pFence), Value);
-}
+}

renderdoc/driver/d3d11/d3d11_device1_wrap.cpp

@@ -370,4 +370,4 @@ HRESULT WrappedID3D11Device::OpenSharedResourceByName(LPCWSTR lpName, DWORD dwDe
   template bool WrappedID3D11Device::CONCAT(Serialise_, func(ReadSerialiser &ser, __VA_ARGS__)); \
   template bool WrappedID3D11Device::CONCAT(Serialise_, func(WriteSerialiser &ser, __VA_ARGS__));
 
-SERIALISED_ID3D11DEVICE1_FUNCTIONS();
+SERIALISED_ID3D11DEVICE1_FUNCTIONS();

renderdoc/driver/d3d11/d3d11_device3_wrap.cpp

@@ -1083,4 +1083,4 @@ HRESULT WrappedID3D11Device::OpenSharedFence(HANDLE hFence, REFIID riid, void **
   template bool WrappedID3D11Device::CONCAT(Serialise_, func(ReadSerialiser &ser, __VA_ARGS__)); \
   template bool WrappedID3D11Device::CONCAT(Serialise_, func(WriteSerialiser &ser, __VA_ARGS__));
 
-SERIALISED_ID3D11DEVICE3_FUNCTIONS();
+SERIALISED_ID3D11DEVICE3_FUNCTIONS();