Update index.js

zxc122333 · zxc122333 · commit 05207a3c2e72 · 2014-10-26T21:52:04.000+08:00
Splice too much？
diff --git a/src/observer/index.js b/src/observer/index.js
@@ -181,7 +181,7 @@ p.convert = function (key, val) {
       var oldChildOb = val && val.__ob__
       if (oldChildOb) {
         var oldBindings = oldChildOb.bindings
-        oldBindings.splice(oldBindings.indexOf(binding))
+        oldBindings.splice(oldBindings.indexOf(binding),1)
       }
       val = newVal
       // add binding to new value
@@ -232,4 +232,4 @@ p.removeVm = function (vm) {
   this.vms.splice(this.vms.indexOf(vm), 1)
 }
 
-module.exports = Observer
+module.exports = Observer

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ p.convert = function (key, val) {`
`181`	`181`	`var oldChildOb = val && val.__ob__`
`182`	`182`	`if (oldChildOb) {`
`183`	`183`	`var oldBindings = oldChildOb.bindings`
`184`		`- oldBindings.splice(oldBindings.indexOf(binding))`
	`184`	`+ oldBindings.splice(oldBindings.indexOf(binding),1)`
`185`	`185`	`}`
`186`	`186`	`val = newVal`
`187`	`187`	`// add binding to new value`
`@@ -232,4 +232,4 @@ p.removeVm = function (vm) {`
`232`	`232`	`this.vms.splice(this.vms.indexOf(vm), 1)`
`233`	`233`	`}`
`234`	`234`
`235`		`-module.exports = Observer`
	`235`	`+module.exports = Observer`