Skip to content

Commit 3abc3ab

Browse files
committed
DATAES-518 - Polishing.
Extract variable. Original pull request: spring-projects#233.
1 parent a1c1394 commit 3abc3ab

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/main/java/org/springframework/data/elasticsearch/core/ReactiveElasticsearchTemplate.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import org.reactivestreams.Publisher;
5151
import org.slf4j.Logger;
5252
import org.slf4j.LoggerFactory;
53+
import org.springframework.data.domain.Pageable;
5354
import org.springframework.data.domain.Sort;
5455
import org.springframework.data.elasticsearch.client.reactive.ReactiveElasticsearchClient;
5556
import org.springframework.data.elasticsearch.core.EntityOperations.AdaptibleEntity;
@@ -241,7 +242,7 @@ private Flux<SearchHit> doFind(Query query, ElasticsearchPersistentEntity<?> ent
241242

242243
SearchSourceBuilder searchSourceBuilder = new SearchSourceBuilder();
243244
searchSourceBuilder.query(mappedQuery(query, entity));
244-
searchSourceBuilder.version(entity.hasVersionProperty()); // This has been true by default before
245+
searchSourceBuilder.version(entity.hasVersionProperty());
245246
searchSourceBuilder.trackScores(query.getTrackScores());
246247

247248
QueryBuilder postFilterQuery = mappedFilterQuery(query, entity);
@@ -263,15 +264,17 @@ private Flux<SearchHit> doFind(Query query, ElasticsearchPersistentEntity<?> ent
263264
request.indicesOptions(query.getIndicesOptions());
264265
}
265266

266-
if (query.getPageable().isPaged()) {
267+
Pageable pageable = query.getPageable();
267268

268-
long offset = query.getPageable().getOffset();
269+
if (pageable.isPaged()) {
270+
271+
long offset = pageable.getOffset();
269272
if (offset > Integer.MAX_VALUE) {
270273
throw new IllegalArgumentException(String.format("Offset must not be more than %s", Integer.MAX_VALUE));
271274
}
272275

273276
searchSourceBuilder.from((int) offset);
274-
searchSourceBuilder.size(query.getPageable().getPageSize());
277+
searchSourceBuilder.size(pageable.getPageSize());
275278

276279
request.source(searchSourceBuilder);
277280
return doFind(prepareSearchRequest(request));

0 commit comments

Comments
 (0)