Skip to content

Commit ba1a780

Browse files
mhalbrittermhalbritter
committed
Merge branch '3.3.x'
Closes gh-42774
2 parents 7c16008 + 73150b7 commit ba1a780

File tree

17 files changed

+75
-73
lines changed

17 files changed

+75
-73
lines changed

‎buildSrc/src/main/java/org/springframework/boot/build/autoconfigure/DocumentAutoConfigurationClasses.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030

3131
import org.gradle.api.DefaultTask;
3232
import org.gradle.api.Task;
33+
import org.gradle.api.file.DirectoryProperty;
3334
import org.gradle.api.file.FileCollection;
34-
import org.gradle.api.file.RegularFileProperty;
3535
import org.gradle.api.tasks.InputFiles;
3636
import org.gradle.api.tasks.OutputDirectory;
3737
import org.gradle.api.tasks.TaskAction;
@@ -57,7 +57,7 @@ public void setAutoConfiguration(FileCollection autoConfiguration) {
5757
}
5858

5959
@OutputDirectory
60-
public abstract RegularFileProperty getOutputDir();
60+
public abstract DirectoryProperty getOutputDir();
6161

6262
@TaskAction
6363
void documentAutoConfigurationClasses() throws IOException {

‎spring-boot-project/spring-boot-actuator-autoconfigure/build.gradle

+3-3
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ def documentationTest = tasks.register("documentationTest", Test) {
211211
filter {
212212
includeTestsMatching("org.springframework.boot.actuate.autoconfigure.endpoint.web.documentation.*")
213213
}
214-
outputs.dir("${buildDir}/generated-snippets")
214+
outputs.dir(layout.buildDirectory.dir("generated-snippets"))
215215
develocity {
216216
predictiveTestSelection {
217217
enabled = false
@@ -229,12 +229,12 @@ def antoraActuatorRestApiLocalAggregateContent = tasks.register("antoraActuator
229229

230230
def antoraActuatorRestApiAggregateContent = tasks.register("antoraActuatorRestApiAggregateContent", Zip) {
231231
dependsOn documentationTest
232-
inputs.dir("${buildDir}/generated-snippets")
232+
inputs.dir(layout.buildDirectory.dir("generated-snippets"))
233233
.withPathSensitivity(PathSensitivity.RELATIVE)
234234
.withPropertyName("generatedSnippets")
235235
destinationDirectory = layout.buildDirectory.dir('generated/docs/antora-content')
236236
archiveClassifier = "actuator-rest-api-aggregate-content"
237-
from("${buildDir}/generated-snippets") {
237+
from(layout.buildDirectory.dir("generated-snippets")) {
238238
into "modules/api/partials/rest/actuator"
239239
}
240240
}

‎spring-boot-project/spring-boot-devtools/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ dependencies {
8484
}
8585

8686
task syncIntTestDependencies(type: Sync) {
87-
destinationDir = file("${buildDir}/dependencies")
87+
destinationDir = file(layout.buildDirectory.dir("dependencies"))
8888
from {
8989
configurations.intTestDependencies
9090
}

‎spring-boot-project/spring-boot-docs/build.gradle

+10-10
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ task aggregatedJavadoc(type: Javadoc) {
212212
dependsOn publishedProjects.javadoc
213213
source publishedProjects.javadoc.source
214214
classpath = project.files(publishedProjects.javadoc.classpath)
215-
destinationDir = project.file "${buildDir}/docs/javadoc"
215+
destinationDir = project.file(project.layout.buildDirectory.dir("docs/javadoc"))
216216
options {
217217
author = true
218218
docTitle = "Spring Boot ${project.version} API"
@@ -245,33 +245,33 @@ task aggregatedJavadoc(type: Javadoc) {
245245

246246
task documentTestSlices(type: org.springframework.boot.build.test.autoconfigure.DocumentTestSlices) {
247247
testSlices = configurations.testSlices
248-
outputFile = file("${buildDir}/generated/docs/test-auto-configuration/documented-slices.adoc")
248+
outputFile = layout.buildDirectory.file("generated/docs/test-auto-configuration/documented-slices.adoc")
249249
}
250250

251251
task documentStarters(type: org.springframework.boot.build.starters.DocumentStarters) {
252-
outputDir = file("${buildDir}/generated/docs/using/starters/")
252+
outputDir = layout.buildDirectory.dir("generated/docs/using/starters/")
253253
}
254254

255255
task documentAutoConfigurationClasses(type: org.springframework.boot.build.autoconfigure.DocumentAutoConfigurationClasses) {
256256
autoConfiguration = configurations.autoConfiguration
257-
outputDir = file("${buildDir}/generated/docs/auto-configuration-classes/documented-auto-configuration-classes/")
257+
outputDir = layout.buildDirectory.dir("generated/docs/auto-configuration-classes/documented-auto-configuration-classes/")
258258
}
259259

260260
task documentDependencyVersionCoordinates(type: org.springframework.boot.build.constraints.DocumentConstrainedVersions) {
261261
dependsOn dependencyVersions
262262
constrainedVersions.set(providers.provider { dependencyVersions.constrainedVersions })
263-
outputFile = file("${buildDir}/generated/docs/dependency-versions/documented-coordinates.adoc")
263+
outputFile = layout.buildDirectory.file("generated/docs/dependency-versions/documented-coordinates.adoc")
264264
}
265265

266266
task documentDependencyVersionProperties(type: org.springframework.boot.build.constraints.DocumentVersionProperties) {
267267
dependsOn dependencyVersions
268268
versionProperties.set(providers.provider { dependencyVersions.versionProperties})
269-
outputFile = file("${buildDir}/generated/docs/dependency-versions/documented-properties.adoc")
269+
outputFile = layout.buildDirectory.file("generated/docs/dependency-versions/documented-properties.adoc")
270270
}
271271

272272
task documentConfigurationProperties(type: org.springframework.boot.build.context.properties.DocumentConfigurationProperties) {
273273
configurationPropertyMetadata = configurations.configurationProperties
274-
outputDir = file("${buildDir}/generated/docs/application-properties")
274+
outputDir = layout.buildDirectory.dir("generated/docs/application-properties")
275275
}
276276

277277
task documentDevtoolsPropertyDefaults(type: org.springframework.boot.build.devtools.DocumentDevtoolsPropertyDefaults) {}
@@ -280,7 +280,7 @@ task runRemoteSpringApplicationExample(type: org.springframework.boot.build.docs
280280
classpath = configurations.remoteSpringApplicationExample
281281
mainClass = "org.springframework.boot.devtools.RemoteSpringApplication"
282282
args = ["https://myapp.example.com", "--spring.devtools.remote.secret=secret", "--spring.devtools.livereload.port=0"]
283-
output = file("$buildDir/example-output/remote-spring-application.txt")
283+
output = layout.buildDirectory.file("example-output/remote-spring-application.txt")
284284
expectedLogging = "Started RemoteSpringApplication in "
285285
applicationJar = "/Users/myuser/.m2/repository/org/springframework/boot/spring-boot-devtools/${project.version}/spring-boot-devtools-${project.version}.jar"
286286
normalizeLiveReloadPort()
@@ -290,7 +290,7 @@ task runSpringApplicationExample(type: org.springframework.boot.build.docs.Appli
290290
classpath = configurations.springApplicationExample + sourceSets.main.output
291291
mainClass = "org.springframework.boot.docs.features.logexample.MyApplication"
292292
args = ["--server.port=0"]
293-
output = file("$buildDir/example-output/spring-application.txt")
293+
output = layout.buildDirectory.file("example-output/spring-application.txt")
294294
expectedLogging = "Started MyApplication in "
295295
normalizeTomcatPort()
296296
}
@@ -299,7 +299,7 @@ task runLoggingFormatExample(type: org.springframework.boot.build.docs.Applicati
299299
classpath = configurations.springApplicationExample + sourceSets.main.output
300300
mainClass = "org.springframework.boot.docs.features.logexample.MyApplication"
301301
args = ["--spring.main.banner-mode=off", "--server.port=0", "--spring.application.name=myapp"]
302-
output = file("$buildDir/example-output/logging-format.txt")
302+
output = layout.buildDirectory.file("example-output/logging-format.txt")
303303
expectedLogging = "Started MyApplication in "
304304
normalizeTomcatPort()
305305
}

‎spring-boot-project/spring-boot-test-autoconfigure/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,5 +137,5 @@ test {
137137

138138
task testSliceMetadata(type: org.springframework.boot.build.test.autoconfigure.TestSliceMetadata) {
139139
sourceSet = sourceSets.main
140-
outputFile = file("${buildDir}/test-slice-metadata.properties")
140+
outputFile = layout.buildDirectory.file("test-slice-metadata.properties")
141141
}

‎spring-boot-project/spring-boot-tools/spring-boot-antlib/build.gradle

+4-4
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ dependencies {
2626
}
2727

2828
task syncIntegrationTestSources(type: Sync) {
29-
destinationDir file("${buildDir}/it")
29+
destinationDir file(layout.buildDirectory.dir("it"))
3030
from file("src/it")
3131
filter(springRepositoryTransformers.ant())
3232
}
@@ -40,7 +40,7 @@ processResources {
4040

4141
task integrationTest {
4242
dependsOn syncIntegrationTestSources, jar
43-
def resultsDir = file("${buildDir}/test-results/integrationTest")
43+
def resultsDir = file(layout.buildDirectory.dir("test-results/integrationTest"))
4444
inputs.dir(file("src/it")).withPathSensitivity(PathSensitivity.RELATIVE).withPropertyName("source")
4545
inputs.files(sourceSets.main.runtimeClasspath).withNormalizer(ClasspathNormalizer).withPropertyName("classpath")
4646
outputs.dirs resultsDir
@@ -62,9 +62,9 @@ task integrationTest {
6262
ant.propertyref(name: "ivy.class.path")
6363
}
6464
plainlistener()
65-
file("${buildDir}/test-results/integrationTest").mkdirs()
65+
file(layout.buildDirectory.dir("test-results/integrationTest")).mkdirs()
6666
xmllistener(toDir: resultsDir)
67-
fileset(dir: "${buildDir}/it", includes: "**/build.xml")
67+
fileset(dir: layout.buildDirectory.dir("it").get().asFile.toString(), includes: "**/build.xml")
6868
}
6969
}
7070
}

‎spring-boot-project/spring-boot-tools/spring-boot-cli/build.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -106,12 +106,12 @@ task tar(type: Tar) {
106106

107107
task homebrewFormula(type: org.springframework.boot.build.cli.HomebrewFormula) {
108108
dependsOn tar
109-
outputDir = file("${buildDir}/homebrew")
109+
outputDir = layout.buildDirectory.dir("homebrew")
110110
template = file("src/main/homebrew/spring-boot.rb")
111111
archive = tar.archiveFile
112112
}
113113

114-
def homebrewFormulaArtifact = artifacts.add("archives", file("${buildDir}/homebrew/spring-boot.rb")) {
114+
def homebrewFormulaArtifact = artifacts.add("archives", file(layout.buildDirectory.file("homebrew/spring-boot.rb"))) {
115115
type "rb"
116116
classifier "homebrew"
117117
builtBy "homebrewFormula"

‎spring-boot-project/spring-boot-tools/spring-boot-loader-tools/build.gradle

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ plugins {
55

66
description = "Spring Boot Loader Tools"
77

8-
def generatedResources = "${buildDir}/generated-resources/main"
8+
Provider<Directory> generatedResources = layout.buildDirectory.dir("generated-resources/main")
99

1010
configurations {
1111
loader {
@@ -51,7 +51,7 @@ task reproducibleLoaderJar(type: Jar) {
5151
reproducibleFileOrder = true
5252
preserveFileTimestamps = false
5353
archiveFileName = "spring-boot-loader.jar"
54-
destinationDirectory = file("${generatedResources}/META-INF/loader")
54+
destinationDirectory = file(generatedResources.map {it.dir("META-INF/loader") })
5555
}
5656

5757
task reproducibleLoaderClassicJar(type: Jar) {
@@ -66,7 +66,7 @@ task reproducibleLoaderClassicJar(type: Jar) {
6666
reproducibleFileOrder = true
6767
preserveFileTimestamps = false
6868
archiveFileName = "spring-boot-loader-classic.jar"
69-
destinationDirectory = file("${generatedResources}/META-INF/loader")
69+
destinationDirectory = file(generatedResources.map { it.dir("META-INF/loader") })
7070
}
7171

7272
task toolsJar(type: Sync) {
@@ -75,7 +75,7 @@ task toolsJar(type: Sync) {
7575
file(configurations.jarmode.incoming.files.singleFile)
7676
}
7777
rename({ "spring-boot-jarmode-tools.jar" })
78-
into(file("${generatedResources}/META-INF/jarmode"))
78+
into(file(generatedResources.map { it.dir("META-INF/jarmode") }))
7979
}
8080

8181
sourceSets {

‎spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/build.gradle

+5-5
Original file line numberDiff line numberDiff line change
@@ -93,19 +93,19 @@ ext {
9393

9494
task copySettingsXml(type: Copy) {
9595
from file("src/intTest/projects/settings.xml")
96-
into "${buildDir}/generated-resources/settings"
96+
into layout.buildDirectory.dir("generated-resources/settings")
9797
filter(springRepositoryTransformers.mavenSettings())
9898
}
9999

100100
sourceSets {
101101
main {
102-
output.dir("${buildDir}/generated/resources/xsd", builtBy: "xsdResources")
102+
output.dir(layout.buildDirectory.dir("generated/resources/xsd"), builtBy: "xsdResources")
103103
}
104104
intTest {
105-
output.dir("${buildDir}/generated-resources", builtBy: ["extractVersionProperties", "copySettingsXml"])
105+
output.dir(layout.buildDirectory.dir("generated-resources"), builtBy: ["extractVersionProperties", "copySettingsXml"])
106106
}
107107
dockerTest {
108-
output.dir("${buildDir}/generated-resources", builtBy: "extractVersionProperties")
108+
output.dir(layout.buildDirectory.dir("generated-resources"), builtBy: "extractVersionProperties")
109109
}
110110
}
111111

@@ -124,7 +124,7 @@ javadoc {
124124

125125
task xsdResources(type: Sync) {
126126
from "src/main/xsd/layers-${project.ext.xsdVersion}.xsd"
127-
into "${buildDir}/generated/resources/xsd/org/springframework/boot/maven"
127+
into layout.buildDirectory.dir("generated/resources/xsd/org/springframework/boot/maven")
128128
rename { fileName -> "layers.xsd" }
129129
}
130130

‎spring-boot-project/spring-boot/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ plugins {
99

1010
description = "Spring Boot"
1111

12-
def tomcatConfigProperties = "$buildDir/tomcat-config-properties"
12+
def tomcatConfigProperties = layout.buildDirectory.dir("tomcat-config-properties")
1313

1414
configurations {
1515
tomcatDistribution

‎spring-boot-system-tests/spring-boot-image-tests/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ configurations {
1414

1515
task syncMavenRepository(type: Sync) {
1616
from configurations.app
17-
into "${buildDir}/system-test-maven-repository"
17+
into layout.buildDirectory.dir("system-test-maven-repository")
1818
}
1919

2020
systemTest {

‎spring-boot-tests/spring-boot-integration-tests/spring-boot-launch-script-tests/build.gradle

+4-4
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,17 @@ dependencies {
2525

2626
task syncMavenRepository(type: Sync) {
2727
from configurations.app
28-
into "${buildDir}/docker-test-maven-repository"
28+
into layout.buildDirectory.dir("docker-test-maven-repository")
2929
}
3030

3131
task syncAppSource(type: org.springframework.boot.build.SyncAppSource) {
3232
sourceDirectory = file("spring-boot-launch-script-tests-app")
33-
destinationDirectory = file("${buildDir}/spring-boot-launch-script-tests-app")
33+
destinationDirectory = file(layout.buildDirectory.dir("spring-boot-launch-script-tests-app"))
3434
}
3535

3636
task buildApp(type: GradleBuild) {
3737
dependsOn syncAppSource, syncMavenRepository
38-
dir = "${buildDir}/spring-boot-launch-script-tests-app"
38+
dir = layout.buildDirectory.dir("spring-boot-launch-script-tests-app")
3939
startParameter.buildCacheEnabled = false
4040
tasks = ["build"]
4141
}
@@ -54,7 +54,7 @@ task syncJdkDownloads(type: Sync) {
5454
dependsOn downloadJdk
5555
from "${project.gradle.gradleUserHomeDir}/caches/springboot/downloads/jdk/bellsoft/"
5656
include "bellsoft-jdk${jdkVersion}-linux-${jdkArch}.tar.gz"
57-
into "${project.buildDir}/downloads/jdk/bellsoft/"
57+
into layout.buildDirectory.dir("downloads/jdk/bellsoft/")
5858
}
5959

6060
tasks.named("processDockerTestResources").configure {

‎spring-boot-tests/spring-boot-integration-tests/spring-boot-loader-classic-tests/build.gradle

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,17 @@ dependencies {
2222

2323
task syncMavenRepository(type: Sync) {
2424
from configurations.app
25-
into "${buildDir}/docker-test-maven-repository"
25+
into layout.buildDirectory.dir("docker-test-maven-repository")
2626
}
2727

2828
task syncAppSource(type: org.springframework.boot.build.SyncAppSource) {
2929
sourceDirectory = file("spring-boot-loader-classic-tests-app")
30-
destinationDirectory = file("${buildDir}/spring-boot-loader-classic-tests-app")
30+
destinationDirectory = file(layout.buildDirectory.dir("spring-boot-loader-classic-tests-app"))
3131
}
3232

3333
task buildApp(type: GradleBuild) {
3434
dependsOn syncAppSource, syncMavenRepository
35-
dir = "${buildDir}/spring-boot-loader-classic-tests-app"
35+
dir = layout.buildDirectory.dir("spring-boot-loader-classic-tests-app")
3636
startParameter.buildCacheEnabled = false
3737
tasks = ["build"]
3838
}

‎spring-boot-tests/spring-boot-integration-tests/spring-boot-loader-tests/build.gradle

+6-6
Original file line numberDiff line numberDiff line change
@@ -28,29 +28,29 @@ dependencies {
2828

2929
task syncMavenRepository(type: Sync) {
3030
from configurations.app
31-
into "${buildDir}/docker-test-maven-repository"
31+
into layout.buildDirectory.dir("docker-test-maven-repository")
3232
}
3333

3434
task syncAppSource(type: org.springframework.boot.build.SyncAppSource) {
3535
sourceDirectory = file("spring-boot-loader-tests-app")
36-
destinationDirectory = file("${buildDir}/spring-boot-loader-tests-app")
36+
destinationDirectory = file(layout.buildDirectory.dir("spring-boot-loader-tests-app"))
3737
}
3838

3939
task buildApp(type: GradleBuild) {
4040
dependsOn syncAppSource, syncMavenRepository
41-
dir = "${buildDir}/spring-boot-loader-tests-app"
41+
dir = layout.buildDirectory.dir("spring-boot-loader-tests-app")
4242
startParameter.buildCacheEnabled = false
4343
tasks = ["build"]
4444
}
4545

4646
task syncSignedJarAppSource(type: org.springframework.boot.build.SyncAppSource) {
4747
sourceDirectory = file("spring-boot-loader-tests-signed-jar")
48-
destinationDirectory = file("${buildDir}/spring-boot-loader-tests-signed-jar")
48+
destinationDirectory = file(layout.buildDirectory.dir("spring-boot-loader-tests-signed-jar"))
4949
}
5050

5151
task buildSignedJarApp(type: GradleBuild) {
5252
dependsOn syncSignedJarAppSource, syncMavenRepository
53-
dir = "${buildDir}/spring-boot-loader-tests-signed-jar"
53+
dir = layout.buildDirectory.dir("spring-boot-loader-tests-signed-jar")
5454
startParameter.buildCacheEnabled = false
5555
tasks = ["build"]
5656
}
@@ -69,7 +69,7 @@ task syncJdkDownloads(type: Sync) {
6969
dependsOn downloadJdk
7070
from "${project.gradle.gradleUserHomeDir}/caches/springboot/downloads/jdk/oracle/"
7171
include "jdk-${oracleJdkVersion}_linux-${oracleJdkArch}_bin.tar.gz"
72-
into "${project.buildDir}/downloads/jdk/oracle/"
72+
into layout.buildDirectory.dir("downloads/jdk/oracle/")
7373
}
7474

7575
tasks.named("processDockerTestResources").configure {

0 commit comments

Comments
 (0)