add more logging

Author: Costin Leau

src/main/java/org/springframework/data/hadoop/mapreduce/JobGenericOptions.java

@@ -19,6 +19,8 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.util.GenericOptionsParser;
 import org.springframework.core.io.Resource;
@@ -31,6 +33,8 @@
  */
 abstract class JobGenericOptions {
 
+	final Log log = LogFactory.getLog(getClass());
+
 	Resource[] files, libJars, archives;
 	String user;
 
@@ -85,7 +89,7 @@ void buildGenericOptions(Configuration cfg) {
 		}
 	}
 
-	static void addResource(Resource[] args, String name, List<String> list) throws IOException {
+	void addResource(Resource[] args, String name, List<String> list) throws IOException {
 		if (!ObjectUtils.isEmpty(args)) {
 			int count = args.length;
 			list.add(name);
@@ -98,6 +102,10 @@ static void addResource(Resource[] args, String name, List<String> list) throws
 				}
 			}
 			list.add(sb.toString());
+
+			if (log.isTraceEnabled()) {
+				log.trace("Adding to generic option arg [" + name + "], resources " + sb.toString());
+			}
 		}
 	}
 

src/main/java/org/springframework/data/hadoop/mapreduce/ParentLastURLClassLoader.java

@@ -19,6 +19,7 @@
 import java.net.URL;
 import java.net.URLClassLoader;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collections;
 import java.util.Enumeration;
 import java.util.List;
@@ -103,4 +104,16 @@ public Enumeration<URL> getResources(String name) throws IOException {
 
 		return Collections.enumeration(urls);
 	}
+	
+    @Override
+    public String toString() {
+		StringBuilder sb = new StringBuilder("ParentLastURLCL\r\nURLs: ");
+		sb.append(Arrays.asList(getURLs()));
+		sb.append("\nParent CL: ");
+		sb.append(getParent());
+		sb.append("\nSystem CL: ");
+		sb.append(system);
+		sb.append("\n");
+        return (sb.toString());
+    }
 }

src/main/java/org/springframework/data/hadoop/mapreduce/ToolExecutor.java

@@ -16,6 +16,7 @@
 package org.springframework.data.hadoop.mapreduce;
 
 import java.security.PrivilegedExceptionAction;
+import java.util.Arrays;
 import java.util.Properties;
 
 import org.apache.hadoop.conf.Configuration;
@@ -53,6 +54,11 @@ int runTool() throws Exception {
 
 		if (t == null) {
 			cl = ClassLoadingUtils.createParentLastClassLoader(jar, beanClassLoader, cfg);
+
+			if (log.isTraceEnabled()) {
+				log.trace("Creating Tool custom classloader " + cl);
+			}
+
 			cfg.setClassLoader(cl);
 
 			// fall-back to main
@@ -62,6 +68,10 @@ int runTool() throws Exception {
 					throw new IllegalArgumentException("no Tool class specified and no Main-Class available");
 				}
 				toolClassName = mainClass;
+
+				if (log.isTraceEnabled()) {
+					log.trace("Discovered MainClass as Tool [" + mainClass + "]");
+				}
 			}
 
 			t = loadTool(toolClassName, cl);
@@ -72,6 +82,10 @@ int runTool() throws Exception {
 
 		final Tool ft = t;
 
+		if (log.isDebugEnabled()) {
+			log.debug("Invoking tool [" + t + "] with args " + Arrays.toString(arguments));
+		}
+
 		try {
 			th.setContextClassLoader(cl);