Skip to content

Commit 8c21235

Browse files
committed
Make tests for builtin declaration
1 parent 5d59594 commit 8c21235

File tree

3 files changed

+7
-15
lines changed

3 files changed

+7
-15
lines changed

lib/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ function parser() {
504504
function parse_decllist() {
505505
// grab ident
506506

507-
if(token.type === 'ident') {
507+
if(token.type === 'ident' || token.type === 'builtin') {
508508
var name = token.data
509509
state.unshift(ident())
510510
state.scope.define(name)
@@ -560,7 +560,7 @@ function parser() {
560560
}
561561

562562
function parse_ident() {
563-
if(token.type !== 'ident') {
563+
if(token.type !== 'ident' && token.type !== 'builtin') {
564564
return unexpected('expected user-defined name, got '+token.data)
565565
}
566566

test/index.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ var ParseArray = require('../direct')
1010
var expectSelectors = require('./selectors-expected.json')
1111
var fixture = path.join(__dirname, 'fixture.glsl')
1212

13-
test.only('selector stream', function(t) {
13+
test('selector stream', function(t) {
1414
var selectors = []
1515

1616
fs.createReadStream(fixture)
@@ -20,13 +20,6 @@ test.only('selector stream', function(t) {
2020
selectors.push(selector(x))
2121
})
2222
.once('end', function() {
23-
// console.log(selectors.length, expectSelectors.length)
24-
// for (let i = 0; i < selectors.length; i++) {
25-
// if (selectors[i].length !== expectSelectors[i].length) {
26-
// console.log(i, selectors[i], expectSelectors[i])
27-
// break
28-
// }
29-
// }
3023
t.deepEqual(selectors, expectSelectors)
3124
t.end()
3225
})
@@ -60,7 +53,7 @@ test('stream().program === array()', function(t) {
6053

6154
var actual = Object.keys(ast.scope).sort()
6255
var expect = [
63-
'a', 'b', 'c', 'eigth', 'empty', 'emptyname'
56+
'a', 'b', 'c', 'distance', 'eigth', 'empty', 'emptyname'
6457
, 'emptynameemptyname', 'fifth', 'first', 'forwarddecl'
6558
, 'fourth', 'gary', 'main', 'one', 'position', 'proj'
6659
, 'second', 'seventh', 'sixth', 'texcoord', 'third', 'two'

test/selectors-expected.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -543,12 +543,11 @@
543543
[ "stmtlist", "stmt", "decl", "placeholder" ],
544544
[ "stmtlist", "stmt", "decl", "placeholder" ],
545545
[ "stmtlist", "stmt", "decl", "keyword" ],
546+
[ "stmtlist", "stmt", "decl", "decllist", "ident" ],
547+
[ "stmtlist", "stmt", "decl", "decllist", "expr", "literal" ],
548+
[ "stmtlist", "stmt", "decl", "decllist", "expr" ],
546549
[ "stmtlist", "stmt", "decl", "decllist" ],
547550
[ "stmtlist", "stmt", "decl" ],
548-
[ "stmtlist", "stmt", "expr", "assign", "builtin" ],
549-
[ "stmtlist", "stmt", "expr", "assign", "literal" ],
550-
[ "stmtlist", "stmt", "expr", "assign" ],
551-
[ "stmtlist", "stmt", "expr" ],
552551
[ "stmtlist", "stmt" ],
553552
[ "stmtlist", "stmt", "decl", "placeholder" ],
554553
[ "stmtlist", "stmt", "decl", "placeholder" ],

0 commit comments

Comments
 (0)