Skip to content

Commit 50106b0

Browse files
authored
Fix android generation linux (o3de#18123) (o3de#18128)
Signed-off-by: Steve Pham <[email protected]>
1 parent d05172a commit 50106b0

File tree

5 files changed

+14
-6
lines changed

5 files changed

+14
-6
lines changed

cmake/3rdParty/BuiltInPackages.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
#include the platform-specific 3rd party packages.
1515
o3de_pal_dir(pal_dir ${CMAKE_CURRENT_LIST_DIR}/Platform/${PAL_PLATFORM_NAME} "${O3DE_ENGINE_RESTRICTED_PATH}" "${LY_ROOT_FOLDER}")
16-
set(LY_PAL_PACKAGE_FILE_NAME ${pal_dir}/BuiltInPackages_${PAL_PLATFORM_NAME_LOWERCASE}${LY_HOST_ARCHITECTURE_NAME_EXTENSION}.cmake)
16+
set(LY_PAL_PACKAGE_FILE_NAME ${pal_dir}/BuiltInPackages_${PAL_PLATFORM_NAME_LOWERCASE}${LY_ARCHITECTURE_NAME_EXTENSION}.cmake)
1717
include(${LY_PAL_PACKAGE_FILE_NAME})
1818

1919
# add the above file to the ALLFILES list, so that they show up in IDEs

cmake/Configurations.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,5 +208,5 @@ endforeach()
208208

209209
# flags are defined per platform, follow platform files under Platform/<PlatformName>/Configurations_<platformname>(_<platformarchitecture>).cmake
210210
o3de_pal_dir(pal_dir ${CMAKE_CURRENT_SOURCE_DIR}/cmake/Platform/${PAL_PLATFORM_NAME} "${O3DE_ENGINE_RESTRICTED_PATH}" "${LY_ROOT_FOLDER}")
211-
include(${pal_dir}/Configurations_${PAL_PLATFORM_NAME_LOWERCASE}${LY_HOST_ARCHITECTURE_NAME_EXTENSION}.cmake)
211+
include(${pal_dir}/Configurations_${PAL_PLATFORM_NAME_LOWERCASE}${LY_ARCHITECTURE_NAME_EXTENSION}.cmake)
212212

cmake/PAL.cmake

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -261,9 +261,12 @@ ly_set(PAL_HOST_PLATFORM_NAME ${LY_HOST_PLATFORM_DETECTION_${CMAKE_SYSTEM_NAME}}
261261
string(TOLOWER ${PAL_HOST_PLATFORM_NAME} PAL_HOST_PLATFORM_NAME_LOWERCASE)
262262
ly_set(PAL_HOST_PLATFORM_NAME_LOWERCASE ${PAL_HOST_PLATFORM_NAME_LOWERCASE})
263263

264-
# In addition to host platform name, set the host platform architecture if supported
265-
if (LY_HOST_ARCHITECTURE_DETECTION_${CMAKE_SYSTEM_NAME})
266-
ly_set(LY_HOST_ARCHITECTURE_NAME_EXTENSION "_${LY_HOST_ARCHITECTURE_DETECTION_${CMAKE_SYSTEM_NAME}}")
264+
# In addition to platform name, set the platform architecture if supported
265+
if (LY_ARCHITECTURE_DETECTION_${PAL_PLATFORM_NAME})
266+
ly_set(LY_ARCHITECTURE_NAME_EXTENSION "_${LY_ARCHITECTURE_DETECTION_${PAL_PLATFORM_NAME}}")
267+
endif()
268+
if (LY_HOST_ARCHITECTURE_DETECTION_${PAL_HOST_PLATFORM_NAME})
269+
ly_set(LY_HOST_ARCHITECTURE_NAME_EXTENSION "_${LY_HOST_ARCHITECTURE_DETECTION_${PAL_HOST_PLATFORM_NAME}}")
267270
endif()
268271

269272

cmake/Platform/Android/PALDetection_android.cmake

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@
99
ly_set(LY_PLATFORM_DETECTION_Android Android)
1010
if(${CMAKE_HOST_SYSTEM_NAME} STREQUAL Darwin)
1111
ly_set(LY_HOST_PLATFORM_DETECTION_Android Mac)
12+
elseif(${CMAKE_HOST_SYSTEM_NAME} STREQUAL Linux)
13+
# Linux supports multiple system architectures
14+
ly_set(LY_HOST_PLATFORM_DETECTION_Android ${CMAKE_HOST_SYSTEM_NAME})
15+
ly_set(LY_HOST_ARCHITECTURE_DETECTION_Android ${CMAKE_HOST_SYSTEM_PROCESSOR})
1216
else()
1317
ly_set(LY_HOST_PLATFORM_DETECTION_Android ${CMAKE_HOST_SYSTEM_NAME})
1418
endif()

cmake/Platform/Linux/PALDetection_linux.cmake

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,5 @@ ly_set(LY_PLATFORM_DETECTION_Linux Linux)
1010
ly_set(LY_HOST_PLATFORM_DETECTION_Linux Linux)
1111

1212
# Linux supports multiple system architectures
13-
ly_set(LY_HOST_ARCHITECTURE_DETECTION_Linux ${CMAKE_SYSTEM_PROCESSOR})
13+
ly_set(LY_ARCHITECTURE_DETECTION_Linux ${CMAKE_SYSTEM_PROCESSOR})
14+
ly_set(LY_HOST_ARCHITECTURE_DETECTION_Linux ${CMAKE_HOST_SYSTEM_PROCESSOR})

0 commit comments

Comments
 (0)