Skip to content

Commit 5e9c517

Browse files
committed
Add parent window to MainTabPageCreateWindow callback
1 parent f9b28ff commit 5e9c517

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

SystemInformer/include/mainwnd.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ typedef enum _PH_MAIN_TAB_PAGE_MESSAGE
168168
{
169169
MainTabPageCreate,
170170
MainTabPageDestroy,
171-
MainTabPageCreateWindow, // HWND *Parameter1 (WindowHandle)
171+
MainTabPageCreateWindow, // HWND *Parameter1 (WindowHandle), HWND Parameter2 (ParentWindow)
172172
MainTabPageSelected, // BOOLEAN Parameter1 (Selected)
173173
MainTabPageInitializeSectionMenuItems, // PPH_MAIN_TAB_PAGE_MENU_INFORMATION Parameter1
174174

SystemInformer/mainwnd.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,7 @@ NTSTATUS PhMwpLoadStage1Worker(
543543
//PPH_STRING windowTitle;
544544
//if (windowTitle = PhMwpInitializeWindowTitle())
545545
//{
546-
// PhSetWindowText(PhMainWndHandle, PhGetString(windowTitle));
546+
// PhSetWindowText((HWND)Parameter, PhGetString(windowTitle));
547547
// PhDereferenceObject(windowTitle);
548548
//}
549549

@@ -573,7 +573,7 @@ NTSTATUS PhMwpLoadStage1Worker(
573573
// Allow WM_PH_ACTIVATE to pass through UIPI. (wj32)
574574
if (PhGetOwnTokenAttributes().Elevated)
575575
{
576-
ChangeWindowMessageFilterEx(PhMainWndHandle, WM_PH_ACTIVATE, MSGFLT_ADD, NULL);
576+
ChangeWindowMessageFilterEx((HWND)Parameter, WM_PH_ACTIVATE, MSGFLT_ADD, NULL);
577577
}
578578

579579
// N.B. Devices tab is handled by the HardwareDevices plug-in. The provider is managed internally
@@ -3477,7 +3477,7 @@ VOID PhMwpSelectionChangedTabControl(
34773477
// Create the tab page window if it doesn't exist. (wj32)
34783478
if (!page->WindowHandle && !page->CreateWindowCalled)
34793479
{
3480-
if (page->Callback(page, MainTabPageCreateWindow, &page->WindowHandle, NULL))
3480+
if (page->Callback(page, MainTabPageCreateWindow, &page->WindowHandle, PhMainWndHandle))
34813481
page->CreateWindowCalled = TRUE;
34823482

34833483
if (page->WindowHandle)

plugins/ExtendedTools/disktab.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ BOOLEAN EtpDiskPageCallback(
102102
0,
103103
3,
104104
3,
105-
PhMainWndHandle,
105+
Parameter2,
106106
NULL,
107107
NULL,
108108
&treelistCreateParams

plugins/ExtendedTools/fwtab.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ BOOLEAN FwTabPageCallback(
7272
0,
7373
3,
7474
3,
75-
PhMainWndHandle,
75+
Parameter2,
7676
NULL,
7777
PluginInstance->DllBase,
7878
&treelistCreateParams

plugins/HardwareDevices/devicetree.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ PDEVICE_TREE DeviceTreeCreate(
176176
}
177177

178178
VOID DeviceTreeFree(
179-
_In_opt_ PDEVICE_TREE Tree
179+
_In_opt_ PDEVICE_TREE Tree
180180
)
181181
{
182182
if (!Tree)
@@ -221,7 +221,7 @@ PDEVICE_TREE DeviceTreeCreateIfNecessary(
221221
}
222222

223223
VOID NTAPI DeviceTreePublish(
224-
_In_opt_ PDEVICE_TREE Tree
224+
_In_opt_ PDEVICE_TREE Tree
225225
)
226226
{
227227
PDEVICE_TREE oldTree;
@@ -392,7 +392,7 @@ static int __cdecl DeviceTreeSortFunction(
392392
sortResult = PhCompareStringRef(&srl, &srr, TRUE);
393393
}
394394
break;
395-
case PhDevicePropertyTypeBinary:
395+
case PhDevicePropertyTypeBinary:
396396
{
397397
sortResult = memcmp(lhs->Binary.Buffer, rhs->Binary.Buffer, min(lhs->Binary.Size, rhs->Binary.Size));
398398
if (sortResult == 0)
@@ -1213,7 +1213,7 @@ BOOLEAN DevicesTabPageCallback(
12131213
0,
12141214
3,
12151215
3,
1216-
PhMainWndHandle,
1216+
Parameter2,
12171217
NULL,
12181218
PluginInstance->DllBase,
12191219
&treelistCreateParams

0 commit comments

Comments
 (0)