Fix FluNavigationView noStackPush

gaetandezeiraud · gaetandezeiraud · commit 282b6ebce052 · 2024-11-28T10:51:38.000+01:00
Fix FluNavigationView noStackPush to verify if an argument is passed. If true, it is better to set the page has a new one in order to update it with the arguments.
diff --git a/src/Qt5/imports/FluentUI/Controls/FluNavigationView.qml b/src/Qt5/imports/FluentUI/Controls/FluNavigationView.qml
@@ -1313,7 +1313,7 @@ Item {
             d.stackItems = d.stackItems.concat(nav_list.model[nav_list.currentIndex])
         }
         function noStackPush(){
-            if(loader_content.source.toString() === url){
+            if(loader_content.source.toString() === url && Object.keys(argument).length === 0){
                 return
             }
             loader_content.setSource(url,argument)
diff --git a/src/Qt6/imports/FluentUI/Controls/FluNavigationView.qml b/src/Qt6/imports/FluentUI/Controls/FluNavigationView.qml
@@ -1314,7 +1314,7 @@ Item {
             d.stackItems = d.stackItems.concat(nav_list.model[nav_list.currentIndex])
         }
         function noStackPush(){
-            if(loader_content.source.toString() === url){
+            if(loader_content.source.toString() === url && Object.keys(argument).length === 0){
                 return
             }
             loader_content.setSource(url,argument)

Original file line number	Diff line number	Diff line change
`@@ -1313,7 +1313,7 @@ Item {`
`1313`	`1313`	`d.stackItems = d.stackItems.concat(nav_list.model[nav_list.currentIndex])`
`1314`	`1314`	`}`
`1315`	`1315`	`function noStackPush(){`
`1316`		`- if(loader_content.source.toString() === url){`
	`1316`	`+ if(loader_content.source.toString() === url && Object.keys(argument).length === 0){`
`1317`	`1317`	`return`
`1318`	`1318`	`}`
`1319`	`1319`	`loader_content.setSource(url,argument)`
Original file line number	Diff line number	Diff line change
`@@ -1314,7 +1314,7 @@ Item {`
`1314`	`1314`	`d.stackItems = d.stackItems.concat(nav_list.model[nav_list.currentIndex])`
`1315`	`1315`	`}`
`1316`	`1316`	`function noStackPush(){`
`1317`		`- if(loader_content.source.toString() === url){`
	`1317`	`+ if(loader_content.source.toString() === url && Object.keys(argument).length === 0){`
`1318`	`1318`	`return`
`1319`	`1319`	`}`
`1320`	`1320`	`loader_content.setSource(url,argument)`