Skip to content

Commit fb023ad

Browse files
SergeGautherieThFabba
authored andcommitted
[VIDEOPRT] IntVideoPortCreateAdapterDeviceObject(): 1+1 trivial fixes
Detected by Cppcheck: funcArgOrderDifferent, redundantAssignment.
1 parent cac13bc commit fb023ad

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

win32ss/drivers/videoprt/videoprt.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,10 @@ IntVideoPortDeferredRoutine(
9090
NTSTATUS
9191
NTAPI
9292
IntVideoPortCreateAdapterDeviceObject(
93-
IN PDRIVER_OBJECT DriverObject,
94-
IN PVIDEO_PORT_DRIVER_EXTENSION DriverExtension,
95-
IN PDEVICE_OBJECT PhysicalDeviceObject,
96-
OUT PDEVICE_OBJECT *DeviceObject OPTIONAL)
93+
_In_ PDRIVER_OBJECT DriverObject,
94+
_In_ PVIDEO_PORT_DRIVER_EXTENSION DriverExtension,
95+
_In_opt_ PDEVICE_OBJECT PhysicalDeviceObject,
96+
_Out_opt_ PDEVICE_OBJECT *DeviceObject)
9797
{
9898
PVIDEO_PORT_DEVICE_EXTENSION DeviceExtension;
9999
ULONG DeviceNumber;
@@ -1046,7 +1046,6 @@ VideoPortScanRom(
10461046

10471047
StringLength = strlen((PCHAR)String);
10481048
Found = FALSE;
1049-
SearchLocation = RomBase;
10501049
for (SearchLocation = RomBase;
10511050
!Found && SearchLocation < RomBase + RomLength - StringLength;
10521051
SearchLocation++)

win32ss/drivers/videoprt/videoprt.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -257,10 +257,10 @@ IntDetachFromCSRSS(PKPROCESS *CallingProcess, PKAPC_STATE ApcState);
257257

258258
NTSTATUS NTAPI
259259
IntVideoPortCreateAdapterDeviceObject(
260-
IN PDRIVER_OBJECT DriverObject,
261-
IN PVIDEO_PORT_DRIVER_EXTENSION DriverExtension,
262-
IN PDEVICE_OBJECT PhysicalDeviceObject OPTIONAL,
263-
OUT PDEVICE_OBJECT *DeviceObject OPTIONAL);
260+
_In_ PDRIVER_OBJECT DriverObject,
261+
_In_ PVIDEO_PORT_DRIVER_EXTENSION DriverExtension,
262+
_In_opt_ PDEVICE_OBJECT PhysicalDeviceObject,
263+
_Out_opt_ PDEVICE_OBJECT *DeviceObject);
264264

265265
NTSTATUS NTAPI
266266
IntVideoPortFindAdapter(

0 commit comments

Comments
 (0)