Skip to content

Commit 70f286c

Browse files
committed
Remove useless and buggy context clean up, close AsyncHttpClient#1268
1 parent fa0c164 commit 70f286c

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,6 @@ public boolean retry(NettyResponseFuture<?> future) {
422422
return false;
423423

424424
if (future.canBeReplayed()) {
425-
// FIXME should we set future.setReuseChannel(false); ?
426425
future.setChannelState(ChannelState.RECONNECTED);
427426
future.getAndSetStatusReceived(false);
428427

@@ -468,12 +467,6 @@ public boolean applyIoExceptionFiltersAndReplayRequest(NettyResponseFuture<?> fu
468467
}
469468

470469
public <T> void sendNextRequest(final Request request, final NettyResponseFuture<T> future) {
471-
// remove attribute in case the channel gets closed so it doesn't try to recover the previous future
472-
Channel channel = future.channel();
473-
if (channel != null) {
474-
// channel can be null when it was closed by the server before it could be set
475-
Channels.setAttribute(channel, null);
476-
}
477470
sendRequest(request, future.getAsyncHandler(), future, true);
478471
}
479472

0 commit comments

Comments
 (0)