minor clean up: rename channelPreempted into acquireChannelLock

Author: slandelle

client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java

@@ -98,12 +98,12 @@ public class ChannelManager {
     private final IOException tooManyConnectionsPerHost;
 
     private final ChannelPool channelPool;
+    private final ChannelGroup openChannels;
+    private final ConcurrentHashMap<Channel, Object> channelId2PartitionKey = new ConcurrentHashMap<>();
     private final boolean maxTotalConnectionsEnabled;
     private final Semaphore freeChannels;
-    private final ChannelGroup openChannels;
     private final boolean maxConnectionsPerHostEnabled;
     private final ConcurrentHashMap<Object, Semaphore> freeChannelsPerHost = new ConcurrentHashMap<>();
-    private final ConcurrentHashMap<Channel, Object> channelId2PartitionKey = new ConcurrentHashMap<>();
 
     private AsyncHttpClientHandler wsHandler;
 
@@ -340,7 +340,7 @@ private boolean tryAcquirePerHost(Object partitionKey) {
         return !maxConnectionsPerHostEnabled || getFreeConnectionsForHost(partitionKey).tryAcquire();
     }
 
-    public void preemptChannel(Object partitionKey) throws IOException {
+    public void acquireChannelLock(Object partitionKey) throws IOException {
         if (!channelPool.isOpen())
             throw PoolAlreadyClosedException.INSTANCE;
         if (!tryAcquireGlobal())
@@ -373,7 +373,7 @@ public void closeChannel(Channel channel) {
         Channels.silentlyCloseChannel(channel);
     }
 
-    public void abortChannelPreemption(Object partitionKey) {
+    public void releaseChannelLock(Object partitionKey) {
         if (maxTotalConnectionsEnabled)
             freeChannels.release();
         if (maxConnectionsPerHostEnabled)

client/src/main/java/org/asynchttpclient/netty/channel/NettyConnectListener.java

@@ -60,7 +60,7 @@ public NettyConnectListener(NettyResponseFuture<T> future,//
 
     public void abortChannelPreemption(Channel channel) {
         if (channelPreempted) {
-            channelManager.abortChannelPreemption(partitionKey);
+            channelManager.releaseChannelLock(partitionKey);
         }
 
         Channels.silentlyCloseChannel(channel);

client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java

@@ -263,14 +263,14 @@ private <T> ListenableFuture<T> sendRequestWithNewChannel(//
         Object partitionKey = future.getPartitionKey();
 
         // we disable channelPreemption when performing next requests
-        final boolean channelPreempted = !performingNextRequest;
+        final boolean acquireChannelLock = !performingNextRequest;
 
         try {
             // Do not throw an exception when we need an extra connection for a
             // redirect.
-            if (channelPreempted) {
+            if (acquireChannelLock) {
                 // if there's an exception here, channel wasn't preempted and resolve won't happen
-                channelManager.preemptChannel(partitionKey);
+                channelManager.acquireChannelLock(partitionKey);
             }
         } catch (Throwable t) {
             abort(null, future, getCause(t));
@@ -285,19 +285,19 @@ private <T> ListenableFuture<T> sendRequestWithNewChannel(//
 
                     @Override
                     protected void onSuccess(List<InetSocketAddress> addresses) {
-                        NettyConnectListener<T> connectListener = new NettyConnectListener<>(future, NettyRequestSender.this, channelManager, channelPreempted, partitionKey);
+                        NettyConnectListener<T> connectListener = new NettyConnectListener<>(future, NettyRequestSender.this, channelManager, acquireChannelLock, partitionKey);
                         NettyChannelConnector connector = new NettyChannelConnector(request.getLocalAddress(), addresses, asyncHandler, clientState, config);
                         if (!future.isDone()) {
                             connector.connect(bootstrap, connectListener);
-                        } else if (channelPreempted) {
-                            channelManager.abortChannelPreemption(partitionKey);
+                        } else if (acquireChannelLock) {
+                            channelManager.releaseChannelLock(partitionKey);
                         }
                     }
 
                     @Override
                     protected void onFailure(Throwable cause) {
-                        if (channelPreempted) {
-                            channelManager.abortChannelPreemption(partitionKey);
+                        if (acquireChannelLock) {
+                            channelManager.releaseChannelLock(partitionKey);
                         }
                         abort(null, future, getCause(cause));
                     }