Drop ChannelPoolPartitionSelector in favor of Predicate, close AsyncHttpClient#1374

Author: slandelle

client/src/main/java/org/asynchttpclient/channel/ChannelPool.java

@@ -14,6 +14,7 @@
 package org.asynchttpclient.channel;
 
 import java.util.Map;
+import java.util.function.Predicate;
 
 import io.netty.channel.Channel;
 
@@ -71,7 +72,7 @@ public interface ChannelPool {
      * 
      * @param selector the selector
      */
-    void flushPartitions(ChannelPoolPartitionSelector selector);
+    void flushPartitions(Predicate<Object> selector);
 
     /**
      * @return The number of idle channels per host.

client/src/main/java/org/asynchttpclient/channel/ChannelPoolPartitionSelector.java

@@ -13,10 +13,11 @@
  */
 package org.asynchttpclient.channel;
 
+import io.netty.channel.Channel;
+
 import java.util.Collections;
 import java.util.Map;
-
-import io.netty.channel.Channel;
+import java.util.function.Predicate;
 
 public enum NoopChannelPool implements ChannelPool {
 
@@ -51,7 +52,7 @@ public void flushPartition(Object partitionKey) {
     }
 
     @Override
-    public void flushPartitions(ChannelPoolPartitionSelector selector) {
+    public void flushPartitions(Predicate<Object> selector) {
     }
 
     @Override

client/src/main/java/org/asynchttpclient/channel/NoopChannelPool.java

@@ -28,11 +28,11 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Function;
+import java.util.function.Predicate;
 import java.util.stream.Collectors;
 
 import org.asynchttpclient.AsyncHttpClientConfig;
 import org.asynchttpclient.channel.ChannelPool;
-import org.asynchttpclient.channel.ChannelPoolPartitionSelector;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -358,11 +358,11 @@ public void flushPartition(Object partitionKey) {
     }
 
     @Override
-    public void flushPartitions(ChannelPoolPartitionSelector selector) {
+    public void flushPartitions(Predicate<Object> selector) {
 
         for (Map.Entry<Object, ConcurrentLinkedDeque<IdleChannel>> partitionsEntry : partitions.entrySet()) {
             Object partitionKey = partitionsEntry.getKey();
-            if (selector.select(partitionKey))
+            if (selector.test(partitionKey))
                 flushPartition(partitionKey, partitionsEntry.getValue());
         }
     }