Skip to content

Commit 323e240

Browse files
authored
proposal to i2c
see talk: espressif#1061 PR on origin master : espressif#1073
1 parent b502fd7 commit 323e240

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

cores/esp32/esp32-hal-i2c.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,9 @@ i2c_err_t i2cAttachSCL(i2c_t * i2c, int8_t scl)
175175
if(i2c == NULL){
176176
return I2C_ERROR_DEV;
177177
}
178+
// digitalWrite(scl, HIGH); // optional before
178179
pinMode(scl, OUTPUT_OPEN_DRAIN | PULLUP);
180+
digitalWrite(scl, HIGH); // tested
179181
pinMatrixOutAttach(scl, I2C_SCL_IDX(i2c->num), false, false);
180182
pinMatrixInAttach(scl, I2C_SCL_IDX(i2c->num), false);
181183
return I2C_ERROR_OK;
@@ -197,7 +199,9 @@ i2c_err_t i2cAttachSDA(i2c_t * i2c, int8_t sda)
197199
if(i2c == NULL){
198200
return I2C_ERROR_DEV;
199201
}
202+
// digitalWrite(sda, HIGH); // optional before
200203
pinMode(sda, OUTPUT_OPEN_DRAIN | PULLUP);
204+
digitalWrite(sda, HIGH); // tested
201205
pinMatrixOutAttach(sda, I2C_SDA_IDX(i2c->num), false, false);
202206
pinMatrixInAttach(sda, I2C_SDA_IDX(i2c->num), false);
203207
return I2C_ERROR_OK;

0 commit comments

Comments
 (0)