Skip to content

Commit c61d3c1

Browse files
committed
$settings and $advancedSettings is included => suppress
Signed-off-by: Lukas Reschke <[email protected]>
1 parent 6f2b4bf commit c61d3c1

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

lib/Saml2/Settings.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,7 @@ private function _loadSettingsFromArray($settings)
288288
*
289289
* @return bool True if the settings info is valid
290290
* @throws OneLogin_Saml2_Error
291+
* @suppress PhanUndeclaredVariable
291292
*/
292293
private function _loadSettingsFromFile()
293294
{
@@ -301,13 +302,15 @@ private function _loadSettingsFromFile()
301302
);
302303
}
303304

304-
include $filename;
305+
/** @var array $settings */
306+
include $filename;
305307

306308
// Add advance_settings if exists
307309

308310
$advancedFilename = $this->getConfigPath().'advanced_settings.php';
309311

310312
if (file_exists($advancedFilename)) {
313+
/** @var array $advancedSettings */
311314
include $advancedFilename;
312315
$settings = array_merge($settings, $advancedSettings);
313316
}

0 commit comments

Comments
 (0)