Removed default value USE_DEFAULT_FEEDBACK_LED_PIN for last parameter of IRsend::begin(bool aEnableLEDFeedback, uint_fast8_t aFeedbackLEDPin).

ArminJo · ArminJo · commit 29564e83e12e · 2024-02-27T11:14:16.000+01:00
diff --git a/changelog.md b/changelog.md
@@ -9,6 +9,7 @@ See also the commit log at github: https://github.com/Arduino-IRremote/Arduino-I
 - Added functions stopTimer(), restartTimer() and restartTimerWithTicksToAdd().
 - Added rawlen and initialGap to IRData.
 - Added ReceiveAndSendHobToHood example.
+- Removed default value USE_DEFAULT_FEEDBACK_LED_PIN for last parameter of IRsend::begin(bool aEnableLEDFeedback, uint_fast8_t aFeedbackLEDPin).
 
 # 4.2.1
 - Fix wrong type of tEnableLEDFeedback in IRSend.hpp and IRReceive.hpp.
diff --git a/examples/AllProtocolsOnLCD/AllProtocolsOnLCD.ino b/examples/AllProtocolsOnLCD/AllProtocolsOnLCD.ino
@@ -354,18 +354,25 @@ void printIRResultOnLCD() {
 
     if (IrReceiver.decodedIRData.protocol == UNKNOWN) {
         /*
-         * Print number of bits received and microseconds of signal
+         * Print number of bits received and hash code or microseconds of signal
          */
         myLCD.setCursor(0, 1);
         uint8_t tNumberOfBits = (IrReceiver.decodedIRData.rawDataPtr->rawlen + 1) / 2;
-        if (tNumberOfBits < 10) {
-            myLCD.print(' '); // padding space
-        }
-        myLCD.print(tNumberOfBits);
+        uint_fast8_t tPrintedStringLength = myLCD.print(tNumberOfBits);
         myLCD.print(F(" bit "));
-        uint_fast8_t tDurationStringLength = myLCD.print(IrReceiver.getTotalDurationOfRawData());
-        myLCD.print(F(" \xE4s")); // \xE4 is micro symbol
-        printSpacesOnLCD(7 - tDurationStringLength);
+
+        if (IrReceiver.decodedIRData.decodedRawData != 0) {
+            if (tNumberOfBits < 10) {
+                myLCD.print('0');
+                tPrintedStringLength++;
+            }
+            myLCD.print('x');
+            tPrintedStringLength += myLCD.print(IrReceiver.decodedIRData.decodedRawData, HEX) + 1;
+        } else {
+            tPrintedStringLength += myLCD.print(IrReceiver.getTotalDurationOfRawData());
+            myLCD.print(F(" \xE4s")); // \xE4 is micro symbol
+        }
+        printSpacesOnLCD(11 - tPrintedStringLength);
         sLastProtocolAddress = 4711;
         sLastCommand = 44711;
 
diff --git a/examples/MicroGirs/MicroGirs.ino b/examples/MicroGirs/MicroGirs.ino
@@ -317,7 +317,7 @@ void setup() {
 #endif
 
 #if defined(IR_SEND_PIN)
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
 #else
     IrSender.begin(3, ENABLE_LED_FEEDBACK, USE_DEFAULT_FEEDBACK_LED_PIN); // Specify send pin and enable feedback LED at default feedback LED pin
 #endif
diff --git a/examples/ReceiveAndSend/ReceiveAndSend.ino b/examples/ReceiveAndSend/ReceiveAndSend.ino
@@ -127,7 +127,7 @@ void setup() {
     printActiveIRProtocols(&Serial);
     Serial.println(F("at pin " STR(IR_RECEIVE_PIN)));
 
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
     Serial.print(F("Ready to send IR signals at pin " STR(IR_SEND_PIN) " on press of button at pin "));
     Serial.println(SEND_BUTTON_PIN);
 }
diff --git a/examples/ReceiveAndSendDistanceWidth/ReceiveAndSendDistanceWidth.ino b/examples/ReceiveAndSendDistanceWidth/ReceiveAndSendDistanceWidth.ino
@@ -99,7 +99,7 @@ void setup() {
     IrReceiver.begin(IR_RECEIVE_PIN, ENABLE_LED_FEEDBACK);
     Serial.println(F("Ready to receive pulse distance/width coded IR signals at pin " STR(IR_RECEIVE_PIN)));
 
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
     Serial.print(F("Ready to send IR signals at pin " STR(IR_SEND_PIN) " on press of button at pin "));
     Serial.println(SEND_BUTTON_PIN);
 }
diff --git a/examples/ReceiveAndSendHob2Hood/ReceiveAndSendHob2Hood.ino b/examples/ReceiveAndSendHob2Hood/ReceiveAndSendHob2Hood.ino
@@ -84,7 +84,7 @@ void setup() {
     IrReceiver.begin(IR_RECEIVE_PIN, ENABLE_LED_FEEDBACK);
 
     Serial.print(F("Ready to receive Hob2Hood IR signals at pin " STR(IR_RECEIVE_PIN)));
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
     Serial.println(F("Send Hob2Hood IR signals at pin " STR(IR_SEND_PIN)));
 }
 
diff --git a/examples/ReceiveDump/ReceiveDump.ino b/examples/ReceiveDump/ReceiveDump.ino
@@ -88,7 +88,7 @@ void setup() {
     Serial.println();
     Serial.println(F("Because of the verbose output (>200 ms at 115200 baud), repeats are not dumped correctly!"));
     Serial.println();
-    Serial.println(F("If you receive protocol NEC, Samsung or LG, run also ReceiveDemo to check if your actual protocol is eventually NEC2, SamsungLG or LG2, which is determined by the repeats"));
+    Serial.println(F("If you receive protocol NEC, Samsung or LG, run also ReceiveDemo to check if your actual protocol is eventually NEC2 or SamsungLG, which is determined by the repeats"));
     Serial.println();
 
 }
diff --git a/examples/ReceiveOneAndSendMultiple/ReceiveOneAndSendMultiple.ino b/examples/ReceiveOneAndSendMultiple/ReceiveOneAndSendMultiple.ino
@@ -123,7 +123,7 @@ void setup() {
     printActiveIRProtocols(&Serial);
     Serial.println(F("at pin " STR(IR_RECEIVE_PIN)));
 
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
     Serial.println(F("Ready to send IR signals at pin " STR(IR_SEND_PIN)));
 }
 
diff --git a/examples/SendAndReceive/SendAndReceive.ino b/examples/SendAndReceive/SendAndReceive.ino
@@ -65,7 +65,7 @@ void setup() {
     Serial.print(F("Ready to receive IR signals of protocols: "));
     printActiveIRProtocols(&Serial);
     Serial.println(F("at pin " STR(IR_RECEIVE_PIN)));
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
     Serial.println(F("Send IR signals at pin " STR(IR_SEND_PIN)));
 
 #if FLASHEND >= 0x3FFF  // For 16k flash or more, like ATtiny1604
diff --git a/examples/SendBoseWaveDemo/SendBoseWaveDemo.ino b/examples/SendBoseWaveDemo/SendBoseWaveDemo.ino
@@ -111,7 +111,7 @@ void setup() {
     Serial.println(F("START " __FILE__ " from " __DATE__ "\r\nUsing library version " VERSION_IRREMOTE));
 
 #if defined(IR_SEND_PIN)
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
     Serial.println(F("Send IR signals at pin " STR(IR_SEND_PIN)));
 #else
     uint8_t tSendPin = 3;
diff --git a/examples/SendDemo/SendDemo.ino b/examples/SendDemo/SendDemo.ino
@@ -58,7 +58,7 @@ void setup() {
     Serial.println(F("START " __FILE__ " from " __DATE__ "\r\nUsing library version " VERSION_IRREMOTE));
 
 #if defined(IR_SEND_PIN)
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
 #  if defined(IR_SEND_PIN_STRING)
     Serial.println(F("Send IR signals at pin " IR_SEND_PIN_STRING));
 #  else
diff --git a/examples/SendLGAirConditionerDemo/SendLGAirConditionerDemo.ino b/examples/SendLGAirConditionerDemo/SendLGAirConditionerDemo.ino
@@ -75,7 +75,7 @@ delay(4000); // To be able to connect Serial monitor after reset or power up and
     /*
      * The IR library setup. That's all!
      */
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
 
 
     Serial.println();
diff --git a/examples/SendProntoDemo/SendProntoDemo.ino b/examples/SendProntoDemo/SendProntoDemo.ino
@@ -64,7 +64,7 @@ void setup() {
     Serial.println(F("START " __FILE__ " from " __DATE__ "\r\nUsing library version " VERSION_IRREMOTE));
     Serial.println(F("Send IR signals at pin " STR(IR_SEND_PIN)));
 
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
 }
 
 void loop() {
diff --git a/examples/SendRawDemo/SendRawDemo.ino b/examples/SendRawDemo/SendRawDemo.ino
@@ -58,7 +58,7 @@ void setup() {
     Serial.println(F("START " __FILE__ " from " __DATE__ "\r\nUsing library version " VERSION_IRREMOTE));
     Serial.println(F("Send IR signals at pin " STR(IR_SEND_PIN)));
 
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
 }
 
 /*
diff --git a/examples/SimpleSender/SimpleSender.ino b/examples/SimpleSender/SimpleSender.ino
@@ -36,8 +36,8 @@ void setup() {
     /*
      * The IR library setup. That's all!
      */
-//    IrSender.begin(); // Start with IR_SEND_PIN as send pin and if NO_LED_FEEDBACK_CODE is NOT defined, enable feedback LED at default feedback LED pin
-    IrSender.begin(DISABLE_LED_FEEDBACK); // Start with IR_SEND_PIN as send pin and disable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
+    disableLEDFeedback(); // Disable feedback LED at default feedback LED pin
 }
 
 /*
diff --git a/examples/UnitTest/UnitTest.ino b/examples/UnitTest/UnitTest.ino
@@ -138,7 +138,7 @@ void setup() {
 #endif
 
 #if defined(IR_SEND_PIN)
-    IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin
+    IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin
 #  if defined(IR_SEND_PIN_STRING)
     Serial.println(F("at pin " IR_SEND_PIN_STRING));
 # else
diff --git a/src/IRremoteInt.h b/src/IRremoteInt.h
@@ -425,11 +425,18 @@ class IRsend {
      */
 #if defined(IR_SEND_PIN)
     void begin();
-    void begin(bool aEnableLEDFeedback, uint_fast8_t aFeedbackLEDPin = USE_DEFAULT_FEEDBACK_LED_PIN);
+    // The default parameter allowed to specify IrSender.begin(7); without errors, if IR_SEND_PIN was defined. But the semantics is not the one the user expect.
+    void begin(bool aEnableLEDFeedback, uint_fast8_t aFeedbackLEDPin); // 4.3.1 Removed default value USE_DEFAULT_FEEDBACK_LED_PIN for last parameter
+    // The next function is a dummy to avoid acceptance of pre 4.3 calls to begin(DISABLE_LED_FEEDBACK);
+    void begin(uint8_t aSendPin)
+#  if !defined (DOXYGEN)
+            __attribute__ ((deprecated ("Error: IR_SEND_PIN is still defined, therefore the function begin(aSendPin) is NOT available. You must disable '#define IR_SEND_PIN' to enable this function.")));
+#  endif
+
     // The next function is a dummy to avoid acceptance of pre 4.0 calls to begin(IR_SEND_PIN, DISABLE_LED_FEEDBACK);
     void begin(uint_fast8_t aSendPin, bool aEnableLEDFeedback)
 #  if !defined (DOXYGEN)
-            __attribute__ ((deprecated ("You must use begin(ENABLE_LED_FEEDBACK) or begin(DISABLE_LED_FEEDBACK) since version 4.0.")));
+            __attribute__ ((deprecated ("You must use begin() and enableLEDFeedback() or disableLEDFeedback() since version 4.3.")));
 #  endif
 #else
     IRsend(uint_fast8_t aSendPin);

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ void setup() {`
`127`	`127`	`printActiveIRProtocols(&Serial);`
`128`	`128`	`Serial.println(F("at pin " STR(IR_RECEIVE_PIN)));`
`129`	`129`
`130`		`- IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin`
	`130`	`+ IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin`
`131`	`131`	`Serial.print(F("Ready to send IR signals at pin " STR(IR_SEND_PIN) " on press of button at pin "));`
`132`	`132`	`Serial.println(SEND_BUTTON_PIN);`
`133`	`133`	`}`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ void setup() {`
`99`	`99`	`IrReceiver.begin(IR_RECEIVE_PIN, ENABLE_LED_FEEDBACK);`
`100`	`100`	`Serial.println(F("Ready to receive pulse distance/width coded IR signals at pin " STR(IR_RECEIVE_PIN)));`
`101`	`101`
`102`		`- IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin`
	`102`	`+ IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin`
`103`	`103`	`Serial.print(F("Ready to send IR signals at pin " STR(IR_SEND_PIN) " on press of button at pin "));`
`104`	`104`	`Serial.println(SEND_BUTTON_PIN);`
`105`	`105`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ void setup() {`
`84`	`84`	`IrReceiver.begin(IR_RECEIVE_PIN, ENABLE_LED_FEEDBACK);`
`85`	`85`
`86`	`86`	`Serial.print(F("Ready to receive Hob2Hood IR signals at pin " STR(IR_RECEIVE_PIN)));`
`87`		`- IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin`
	`87`	`+ IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin`
`88`	`88`	`Serial.println(F("Send Hob2Hood IR signals at pin " STR(IR_SEND_PIN)));`
`89`	`89`	`}`
`90`	`90`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ void setup() {`
`88`	`88`	`Serial.println();`
`89`	`89`	`Serial.println(F("Because of the verbose output (>200 ms at 115200 baud), repeats are not dumped correctly!"));`
`90`	`90`	`Serial.println();`
`91`		`- Serial.println(F("If you receive protocol NEC, Samsung or LG, run also ReceiveDemo to check if your actual protocol is eventually NEC2, SamsungLG or LG2, which is determined by the repeats"));`
	`91`	`+ Serial.println(F("If you receive protocol NEC, Samsung or LG, run also ReceiveDemo to check if your actual protocol is eventually NEC2 or SamsungLG, which is determined by the repeats"));`
`92`	`92`	`Serial.println();`
`93`	`93`
`94`	`94`	`}`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ void setup() {`
`123`	`123`	`printActiveIRProtocols(&Serial);`
`124`	`124`	`Serial.println(F("at pin " STR(IR_RECEIVE_PIN)));`
`125`	`125`
`126`		`- IrSender.begin(); // Start with IR_SEND_PIN as send pin and enable feedback LED at default feedback LED pin`
	`126`	`+ IrSender.begin(); // Start with IR_SEND_PIN -which is defined in PinDefinitionsAndMore.h- as send pin and enable feedback LED at default feedback LED pin`
`127`	`127`	`Serial.println(F("Ready to send IR signals at pin " STR(IR_SEND_PIN)));`
`128`	`128`	`}`
`129`	`129`